Paths

Table of Contentst

Differential D13546

[lib] Show viewer's username as thread name for PRIVATE threads if no thread name specified
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 9:01 AM

	Unknown Object (File)
	Sun, Nov 10, 4:20 PM

	Unknown Object (File)
	Fri, Nov 8, 3:01 AM

	Unknown Object (File)
	Fri, Nov 8, 3:01 AM

	Unknown Object (File)
	Sat, Nov 2, 9:17 AM

	Unknown Object (File)
	Fri, Nov 1, 8:46 PM

	Unknown Object (File)
	Fri, Nov 1, 4:46 PM

	Unknown Object (File)
	Fri, Nov 1, 6:08 AM

View All 38 Files

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMMfc73fd3a1f7e: [lib] Show viewer's username as thread name for PRIVATE threads if no thread…

Summary

We should treat PRIVATE the same as GENESIS_PRIVATE here.

Depends on D13545

Test Plan

Confirm that I see eg. "ashoat" instead of "just you" for PRIVATE thread uiName

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 10:05 PM

ashoat added a child revision: D13547: [lib] Make sure we set isViewer in useExistingThreadInfoFinder.

Harbormaster completed remote builds in B31962: Diff 44727.Sep 30 2024, 11:01 PM

ashoat requested review of this revision.Sep 30 2024, 11:01 PM

tomek accepted this revision.Oct 1 2024, 8:13 AM

This revision is now accepted and ready to land.Oct 1 2024, 8:13 AM

Closed by commit rCOMMfc73fd3a1f7e: [lib] Show viewer's username as thread name for PRIVATE threads if no thread… (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfc73fd3a1f7e: [lib] Show viewer's username as thread name for PRIVATE threads if no thread….

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

7 lines

Diff 44776

lib/shared/thread-utils.js

Loading...