Paths

Table of Contentst

Differential D13547

[lib] Make sure we set isViewer in useExistingThreadInfoFinder
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 11:53 AM

	Unknown Object (File)
	Wed, Dec 18, 11:53 AM

	Unknown Object (File)
	Wed, Dec 18, 11:52 AM

	Unknown Object (File)
	Wed, Dec 18, 11:52 AM

	Unknown Object (File)
	Nov 21 2024, 6:23 PM

	Unknown Object (File)
	Nov 19 2024, 8:59 AM

	Unknown Object (File)
	Nov 19 2024, 8:58 AM

	Unknown Object (File)
	Nov 10 2024, 4:20 PM

View All 38 Files

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder

Summary

When we call createPendingThread in useExistingThreadInfoFinder, we need to include isViewer in order to make sure a PRIVATE thread is rendered as eg. "ashoat" instead of "just you". This is because the naming is based on ifJustViewer, which only applies if the members list only includes the viewer.

Depends on D13546

Test Plan

Confirm that I see eg. "ashoat" instead of "just you" for PRIVATE thread uiName

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 10:06 PM

ashoat added a child revision: D13548: [lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread.

Harbormaster completed remote builds in B31963: Diff 44728.Sep 30 2024, 11:06 PM

ashoat requested review of this revision.Sep 30 2024, 11:06 PM

tomek accepted this revision.Oct 1 2024, 8:14 AM

This revision is now accepted and ready to land.Oct 1 2024, 8:14 AM

Closed by commit rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

5 lines

Diff 44777

lib/shared/thread-utils.js

Loading...