This is safe because when sortedMembers in usePotentialMemberItems sets notFriendNotice, it also sets an alert.
Depends on D13543
Differential D13544 Authored by ashoat on Sep 30 2024, 10:01 PM.
Details Summary This is safe because when sortedMembers in usePotentialMemberItems sets notFriendNotice, it also sets an alert. Depends on D13543 Test Plan Careful reading of the code indicates that this is a no-op
Diff Detail
Event TimelineHarbormaster completed remote builds in B31960: Diff 44725.Sep 30 2024, 10:52 PM2024-09-30 22:52:27 (UTC-7) This revision is now accepted and ready to land.Oct 1 2024, 8:07 AM2024-10-01 08:07:42 (UTC-7) Closed by commit rCOMM528961244cdc: [web] Swap order of conditions in ChatThreadComposer onSelectUserFromSearch (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM2024-10-01 09:07:16 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 44774 web/chat/chat-thread-composer.react.js
|