[lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in getNameForThreadEntity
ClosedPublic
Actions

Authored by ashoat on Oct 1 2024, 5:11 AM.

Details

Reviewers

tomek
kamil
inka

Commits

rCOMMd6d57ba2dde9: [lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in…

Summary

This diff is a no-op, as both of these return the same thing when passed to threadNoun. I thought it would be better to use PERSONAL here, to reduce the number of places in the codebase we use GENESIS_PERSONAL.

Depends on D13551

Test Plan

Careful code inspection

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 1 2024, 5:11 AM

ashoat added a child revision: D13553: [web] Use PRIVATE instead of GENESIS_PRIVATE in baseThreadInfo passed to useExistingThreadInfoFinder.

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 1 2024, 5:27 AM

Harbormaster failed remote builds in B31968: Diff 44733!

Rebase

Harbormaster completed remote builds in B31972: Diff 44737.Oct 1 2024, 6:56 AM

ashoat requested review of this revision.Oct 1 2024, 6:56 AM

tomek accepted this revision.Oct 1 2024, 3:23 PM

This revision is now accepted and ready to land.Oct 1 2024, 3:23 PM

Closed by commit rCOMMd6d57ba2dde9: [lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in…. · Explain WhyOct 1 2024, 4:07 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd6d57ba2dde9: [lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in….

Revision Contents
Changeset List

Path

Size

lib/

utils/

entity-text.js

2 lines

Diff 44782

View Options

[lib] Use PERSONAL instead of GENESIS_PERSONAL for default thread noun in getNameForThreadEntityClosedPublicActions