Paths

Table of Contentst

Differential D13547

[lib] Make sure we set isViewer in useExistingThreadInfoFinder
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 30, 10:06 PM.

Tags

None

Referenced Files

	F2860732: D13547.diff
	Tue, Oct 1, 7:32 PM

	F2860173: D13547.id44777.diff
	Tue, Oct 1, 4:24 PM

	F2859631: D13547.id.diff
	Tue, Oct 1, 2:22 PM

	F2859594: D13547.diff
	Tue, Oct 1, 2:02 PM

	F2859169: D13547.id44728.diff
	Tue, Oct 1, 12:49 PM

	F2859112: D13547.diff
	Tue, Oct 1, 12:32 PM

	F2859020: D13547.id.diff
	Tue, Oct 1, 12:16 PM

	F2853628: D13547.id44728.diff
	Mon, Sep 30, 10:29 PM

View All 10 Files

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder

Summary

When we call createPendingThread in useExistingThreadInfoFinder, we need to include isViewer in order to make sure a PRIVATE thread is rendered as eg. "ashoat" instead of "just you". This is because the naming is based on ifJustViewer, which only applies if the members list only includes the viewer.

Depends on D13546

Test Plan

Confirm that I see eg. "ashoat" instead of "just you" for PRIVATE thread uiName

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mon, Sep 30, 10:06 PM

ashoat added a child revision: D13548: [lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread.

Harbormaster completed remote builds in B31963: Diff 44728.Mon, Sep 30, 11:06 PM

ashoat requested review of this revision.Mon, Sep 30, 11:06 PM

tomek accepted this revision.Tue, Oct 1, 8:14 AM

This revision is now accepted and ready to land.Tue, Oct 1, 8:14 AM

Closed by commit rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder (authored by ashoat). · Explain WhyTue, Oct 1, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

5 lines

Diff 44728

lib/shared/thread-utils.js

Loading...