Paths

Table of Contentst

Differential D13546

[lib] Show viewer's username as thread name for PRIVATE threads if no thread name specified
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 30, 10:05 PM.

Tags

None

Referenced Files

	F2860720: D13546.diff
	Tue, Oct 1, 7:30 PM

	F2860655: D13546.id.diff
	Tue, Oct 1, 7:03 PM

	F2853627: D13546.id44727.diff
	Mon, Sep 30, 10:29 PM

	F2853530: D13546.id.diff
	Mon, Sep 30, 10:27 PM

	F2853340: D13546.diff
	Mon, Sep 30, 10:11 PM

Subscribers

None

Details

Reviewers

tomek
kamil
inka

Commits

rCOMMfc73fd3a1f7e: [lib] Show viewer's username as thread name for PRIVATE threads if no thread…

Summary

We should treat PRIVATE the same as GENESIS_PRIVATE here.

Depends on D13545

Test Plan

Confirm that I see eg. "ashoat" instead of "just you" for PRIVATE thread uiName

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mon, Sep 30, 10:05 PM

ashoat added a child revision: D13547: [lib] Make sure we set isViewer in useExistingThreadInfoFinder.

Harbormaster completed remote builds in B31962: Diff 44727.Mon, Sep 30, 11:01 PM

ashoat requested review of this revision.Mon, Sep 30, 11:01 PM

tomek accepted this revision.Tue, Oct 1, 8:13 AM

This revision is now accepted and ready to land.Tue, Oct 1, 8:13 AM

Closed by commit rCOMMfc73fd3a1f7e: [lib] Show viewer's username as thread name for PRIVATE threads if no thread… (authored by ashoat). · Explain WhyTue, Oct 1, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfc73fd3a1f7e: [lib] Show viewer's username as thread name for PRIVATE threads if no thread….

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

7 lines

Diff 44727

lib/shared/thread-utils.js

Loading...