[lib] Add handler component for retrying holder processing
ClosedPublic
Actions

Authored by bartek on Wed, Oct 9, 2:03 AM.

Details

Reviewers

Commits

Summary

Address ENG-9290.
Added handler component that watches for NOT_ESTABLISHED and NOT_REMOVED holders and retries their processing.

Test Plan

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

bartek held this revision as a draft.

bartek published this revision for review.Wed, Oct 9, 2:58 AM

bartek added inline comments.

lib/handlers/holders-handler.react.js
4	I was also considering `_throttle` here. There's no difference if holder changes (and failures) are infrequent. But when there's lots of holder "traffic": debounce will wait until there's no traffic for 5000ms and then start processing throttle will retry every 5000ms despite constant traffic check this playground
44–46	Just a note - I deliberately used `useMemo` instead of `useCallback` for debounce: The latter shouldn't be used with higher order funcs:, source 1, source 2 ESLint complains: `React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps`

tomek added inline comments.

lib/handlers/holders-handler.react.js
7–11	We can merge these
17	This feels quite frequent. Do you think it makes sense?

This revision is now accepted and ready to land.Thu, Oct 10, 5:03 AM

lib/handlers/holders-handler.react.js
17	You might be right, maybe increasing to 30s would be better? Or even 60? But I'm worrying about the debounce vs throttle problem I described above - perhaps we should use throttle then