Page MenuHomePhabricator
Differential D13701

[keyserver] add signer_uuid and neynar webhook secret
ClosedPublic
Actions

Authored by will on Oct 13 2024, 1:37 PM.
Tags
None
Referenced Files
F5121921: D13701.diff
Thu, Apr 3, 12:14 PM
F5119373: D13701.id45547.diff
Thu, Apr 3, 3:40 AM
Unknown Object (File)
Wed, Apr 2, 2:43 PM
Unknown Object (File)
Wed, Apr 2, 12:27 PM
Unknown Object (File)
Tue, Apr 1, 10:17 PM
Unknown Object (File)
Tue, Apr 1, 11:53 AM
Unknown Object (File)
Fri, Mar 28, 2:33 PM
Unknown Object (File)
Sun, Mar 23, 12:58 PM
View All 88 Files
Subscribers
tomek

Details

Reviewers
varun
ashoat
inka
Commits
rCOMM4628129f5d87: [keyserver] add signer_uuid and neynar webhook secret
Summary

This adds optional signerUuid and neynarWebhookSecret as options to our neynar config

Test Plan

Accessed values in a later diff. flow check

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 13 2024, 1:37 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 13 2024, 1:37 PM
Harbormaster completed remote builds in B32202: Diff 45098.Oct 13 2024, 1:59 PM
will requested review of this revision.Oct 13 2024, 1:59 PM
ashoat accepted this revision.Oct 14 2024, 12:06 PM

Accepting, but TBD on whether we need all of these

This revision is now accepted and ready to land.Oct 14 2024, 12:06 PM
will added a child revision: D13754: [keyserver] accept webhook cast created events tagging comm.Oct 20 2024, 9:52 PM
will mentioned this in D13755: [keyserver] moving getting neynar config to function.Oct 20 2024, 10:00 PM
will updated this revision to Diff 45366.Oct 23 2024, 11:14 PM

uppercase Uuid to UUID

Harbormaster completed remote builds in B32361: Diff 45366.Oct 23 2024, 11:32 PM
Closed by commit rCOMM4628129f5d87: [keyserver] add signer_uuid and neynar webhook secret (authored by will). · Explain WhyOct 31 2024, 12:18 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM4628129f5d87: [keyserver] add signer_uuid and neynar webhook secret.
will mentioned this in rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
6 lines

Diff 45098

View Options

keyserver/src/utils/fc-cache.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines