Page MenuHomePhabricator

[lib] Show sidebars in top level if parent thread is in a separate tab
Needs ReviewPublic

Authored by will on Tue, Oct 15, 2:51 PM.
Tags
None
Referenced Files
F2979247: D13719.id45211.diff
Tue, Oct 15, 3:35 PM
F2979204: D13719.id.diff
Tue, Oct 15, 3:34 PM
F2979198: D13719.diff
Tue, Oct 15, 3:34 PM
Subscribers

Details

Reviewers
ashoat
varun
Summary

This shows sidebars on top level if their parent threads have a differing notif setting (home/mute).

In the next diff, the sidebar items listed under a parent that exist as top level items in a different tab will be removed

Test Plan

In a future diff, allowed the notif setting to be changed for sidebars. Tested the following

  • Confirmed that moving the child thread had it appear in a separate tab as a top level item
  • Confirmed that having a sidebar thread and its parent in the same tab did not result in a top level sidebar thread appearing
  • Confirmed moving the parent into the same tab caused the child to no longer appear as top level and into a different tab resulted in a top level item

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

lib/selectors/chat-selectors.js
274

I went by threadIsHome to compare tabs. Do we ever plan to introduce more tabs than muted and home?

lib/shared/thread-utils.js
1430

This allows sidebar threads to render and threadIsTopLevel filters them out

will marked an inline comment as not done.Tue, Oct 15, 3:02 PM
will marked an inline comment as not done.
will added inline comments.
lib/shared/thread-utils.js
1430

as**

will requested review of this revision.Tue, Oct 15, 3:20 PM