In my last review, I suggested doing this differently:

To make this work, we'd need some changes to createThread, so that it when it calls changeRole for these users, it passes a different role ID

I'd suggest replacing the definition as such:

// old
async function createThread(
  viewer: Viewer,
  request: ServerNewThinThreadRequest,
  options?: CreateThreadOptions,
): Promise<NewThreadResponse> {
  ...
}
// new
type CreateThreadRequest = $ReadOnly<{
  ...ServerNewThinThreadRequest,
  +initialAdminIDs?: ?$ReadOnlyArray<string>,
  +dontMakeViewerAdmin?: ?boolean,
}>;
async function createThread(
  viewer: Viewer,
  request: CreateThreadRequest,
  options?: CreateThreadOptions,
): Promise<NewThreadResponse> {
  ...
}

I was suggesting this approach because I wanted to avoid a robotext being printed about a user being promoted to admin. This matches the behavior introduced in D13300.

Can you walk me through why you decided to take a different approach here? I'm open to printing the robotext, but we should probably update joinThread too if that's the approach we want to take.

Do we need to wait until this point to start this promise?

We shouldn't need the ?? false here. It looks like you're using a single type in D13781 when you should be used two types

Did this end up happening in a separate diff?

Talked with Ashoat

^that got cut off. Going to rebase with the suggested changes

Why do you wait until the above two promises conclude before starting this one?

Feels kinda messy. How about this instead?

const initialMemberIDs = [...new Set([
  leadUserID,
  taggerUserID,
  communityAdminID,
].filter(Boolean))];

1. Why do we wait until this point to start this promise?
2. Do we end up needing this elsewhere? Wondering why it's here instead of being inside createTaggedFarcasterCommunity

This comment from the prior review wasn't responded to:

We shouldn't need the ?? false here. It looks like you're using a single type in D13781 when you should be used two types