Page MenuHomePhabricator
Differential D13956

[lib] Log out on failed Tunnelbroker auth
ClosedPublic
Actions

Authored by bartek on Nov 18 2024, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 1:29 PM
Unknown Object (File)
Fri, Dec 13, 1:58 PM
Unknown Object (File)
Fri, Dec 13, 4:33 AM
Unknown Object (File)
Mon, Dec 9, 8:35 PM
Unknown Object (File)
Sat, Dec 7, 7:07 PM
Unknown Object (File)
Sat, Dec 7, 4:51 AM
Unknown Object (File)
Mon, Dec 2, 4:48 AM
Unknown Object (File)
Thu, Nov 28, 4:16 AM
View All 19 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
ashoat
Commits
rCOMM507081c04dad: [lib] Log out on failed Tunnelbroker auth
Summary

Address ENG-9525.
When verification of initialization message fails, log out the device

Depends on D13955

Test Plan

Mocked the initialization message to contain invalid CSAT. The device was logged out.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 18 2024, 6:48 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 18 2024, 6:48 AM
Harbormaster completed remote builds in B32697: Diff 45863.Nov 18 2024, 7:17 AM
bartek added a child revision: D13989: [lib][keyserver] Handle invalid CSAT on blob download.Nov 21 2024, 3:59 AM
bartek published this revision for review.Nov 21 2024, 9:12 AM
bartek added a reviewer: ashoat. bartek removed 1 blocking reviewer(s): kamil.
bartek added inline comments.
lib/tunnelbroker/tunnelbroker-context.js
299–302 ↗(On Diff #45863)

Doing return here doesn't change the context state, so it's still "awaiting connection" (connected = false). After the hook logs out the user, the createInitMessage() will start returning null and the connection will be closed.

ashoat accepted this revision.Nov 21 2024, 6:19 PM
This revision is now accepted and ready to land.Nov 21 2024, 6:19 PM
bartek added a child revision: D14030: [keyserver] Handle invalid CSAT in Tunnelbroker socket.Sun, Nov 24, 11:36 PM
bartek mentioned this in D14031: [lib] Handle invalid CSAT in Identity Search context.
Closed by commit rCOMM507081c04dad: [lib] Log out on failed Tunnelbroker auth (authored by bartek). · Explain WhyFri, Nov 29, 5:02 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM507081c04dad: [lib] Log out on failed Tunnelbroker auth.
bartek mentioned this in rCOMMe6ee808615e7: [lib] Handle invalid CSAT in Identity Search context.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
8 lines

Diff 46131

View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...