Page MenuHomePhabricator
Differential D14098

[native] Fix reanimated cancelAnimation flow type
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 6:58 AM.
Tags
None
Referenced Files
F3507264: D14098.diff
Fri, Dec 20, 8:03 PM
F3507238: D14098.id46399.diff
Fri, Dec 20, 7:55 PM
F3504880: D14098.id46461.diff
Fri, Dec 20, 11:01 AM
F3499884: D14098.id46316.diff
Fri, Dec 20, 12:26 AM
Unknown Object (File)
Thu, Dec 19, 1:16 PM
Unknown Object (File)
Wed, Dec 18, 8:18 AM
Unknown Object (File)
Tue, Dec 17, 5:27 PM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe42de0724ee9: [native] Fix reanimated cancelAnimation flow type
Summary

I found a mistake in CancelAnimation flow type. It makes no sense it takes a number as an argument and in original ts types it takes a SharedValue: https://github.com/software-mansion/react-native-reanimated/blob/2.17.0/src/reanimated2/animation/util.ts#L281. I fixed it because I'll need this in later diff.

Test Plan

Flow and swipe a message.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 6:58 AM
angelika held this revision as a draft.
angelika mentioned this in D14099: [native] Add reanimated makeMutable function type.Wed, Dec 11, 7:05 AM
angelika added a child revision: D14099: [native] Add reanimated makeMutable function type.Wed, Dec 11, 7:22 AM
Harbormaster completed remote builds in B32998: Diff 46316.Wed, Dec 11, 7:26 AM
angelika published this revision for review.Wed, Dec 11, 4:52 PM
ashoat accepted this revision.Wed, Dec 11, 5:02 PM

Thanks for finding this. Just wondering – did you find out because something was broken through testing, or because you observed that Flow was printing an error when the code looked right?

This revision is now accepted and ready to land.Wed, Dec 11, 5:02 PM
angelika added a comment.Thu, Dec 12, 9:05 AM
In D14098#393678, @ashoat wrote:

Thanks for finding this. Just wondering – did you find out because something was broken through testing, or because you observed that Flow was printing an error when the code looked right?

It went like this:

  • I used cancelAnimation without .value
  • Flow raised an error
  • I investigated it and found out the type was not right
  • Flow complained again in swipeable-message.react.js
  • I fixed it there and tested in the app to make sure nothing is broken
ashoat added a comment.Thu, Dec 12, 10:42 AM

Thanks for sharing!

angelika updated this revision to Diff 46398.Fri, Dec 13, 5:24 AM

Rebase and address feedback

Harbormaster completed remote builds in B33076: Diff 46398.Fri, Dec 13, 5:42 AM
angelika updated this revision to Diff 46461.Mon, Dec 16, 6:18 AM

Rebase

Harbormaster completed remote builds in B33120: Diff 46461.Mon, Dec 16, 6:36 AM
Closed by commit rCOMMe42de0724ee9: [native] Fix reanimated cancelAnimation flow type (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMe42de0724ee9: [native] Fix reanimated cancelAnimation flow type.
angelika mentioned this in rCOMM78c5b78ee76d: [native] Add reanimated makeMutable function type.

Revision Contents
Changeset List

PathSize
native/
chat/
2 lines
flow-typed/
npm/
2 lines

Diff 46316

View Options

native/chat/swipeable-message.react.js

Loading...
View Options

native/flow-typed/npm/react-native-reanimated_v2.x.x.js

Loading...