Page MenuHomePhabricator
Differential D14119

[native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to Reanimate V2 API
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 8:33 AM.
Tags
None
Referenced Files
F3492706: D14119.diff
Thu, Dec 19, 1:05 AM
F3491713: D14119.id46337.diff
Wed, Dec 18, 8:02 PM
F3489103: D14119.id46413.diff
Wed, Dec 18, 11:36 AM
Unknown Object (File)
Tue, Dec 17, 9:58 PM
Unknown Object (File)
Mon, Dec 16, 10:38 PM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM76af728667fe: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to…
Summary

This is a straightforward change: use progressV2 variable, use useAnimatedStyle instead of useMemo for styles and put the interpolation in useAnimatedStyle worklet.

Depends on D14118

Test Plan

Open up text message tooltip and verify it's animated correctly. Also navigate to the thread from the tooltip and verify the transition looks right.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 8:33 AM
angelika held this revision as a draft.
angelika added a child revision: D14120: [native] Migrate threadColorOverride in useAnimatedMessageTooltipButton to Reanimate V2 API.Wed, Dec 11, 8:46 AM
Harbormaster completed remote builds in B33019: Diff 46337.Wed, Dec 11, 10:40 AM
angelika published this revision for review.Wed, Dec 11, 5:27 PM
ashoat accepted this revision.Wed, Dec 11, 7:51 PM
This revision is now accepted and ready to land.Wed, Dec 11, 7:51 PM
angelika updated this revision to Diff 46413.Fri, Dec 13, 5:35 AM

Rebase and address feedback

Harbormaster completed remote builds in B33091: Diff 46413.Fri, Dec 13, 7:40 AM
angelika updated this revision to Diff 46476.Mon, Dec 16, 6:22 AM

Rebase

Harbormaster completed remote builds in B33135: Diff 46476.Mon, Dec 16, 8:32 AM
Closed by commit rCOMM76af728667fe: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to… (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM76af728667fe: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to….

Revision Contents
Changeset List

PathSize
native/
chat/
27 lines

Diff 46476

View Options

native/chat/utils.js

Loading...