Details
Call this callback when QR auth flow is finished - devices is removed from device list, secondary device is visually logged out.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/account/qr-auth/qr-auth-context-provider.js | ||
|---|---|---|
| 249 ↗ | (On Diff #46386) | Actually, we should throw an error here |
| native/account/qr-auth/qr-auth-context-provider.js | ||
|---|---|---|
| 60–62 ↗ | (On Diff #46386) | This is just in case to ignore messages when there is no ongoing QR auth, e.g., Secondary responded,d but we're already in the process of removing it and we communicated to the user that it is not responding. |
Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me
| native/account/qr-auth/qr-auth-context-provider.js | ||
|---|---|---|
| 97–101 ↗ | (On Diff #46386) | Wondering whether we should add some conditions here. We early return in a couple of scenarios, but are we sure that all the cases are handled? I guess it might be safer to wrap this with an if with appropriate conditions. |
| native/account/qr-auth/qr-auth-context-provider.js | ||
|---|---|---|
| 97–101 ↗ | (On Diff #46386) | In if above we early-exist or any message different that SECONDARY_DEVICE_REGISTRATION_SUCCESS so this should be safe |