Page MenuHomePhabricator
Differential D3083

[services] Backup - Database - add Item
ClosedPublic
Actions

Authored by • karol on Feb 3 2022, 6:49 AM.
Tags
None
Referenced Files
F4947612: D3083.diff
Wed, Mar 19, 4:44 PM
Unknown Object (File)
Sat, Mar 15, 3:23 AM
Unknown Object (File)
Sat, Mar 15, 3:23 AM
Unknown Object (File)
Sat, Mar 15, 3:23 AM
Unknown Object (File)
Sat, Mar 15, 3:23 AM
Unknown Object (File)
Sat, Mar 15, 3:23 AM
Unknown Object (File)
Tue, Mar 4, 12:34 AM
Unknown Object (File)
Thu, Feb 20, 2:37 PM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
varun
ashoat
Commits
rCOMM035dcc8fa6be: [services] Backup - Database - add Item
Summary

Parent class for all database items

Test Plan

-

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Feb 3 2022, 6:49 AM
Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 3 2022, 6:49 AM
• karol published this revision for review.Feb 3 2022, 7:09 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun.
Harbormaster completed remote builds in B6481: Diff 9213.Feb 3 2022, 8:37 AM
tomek accepted this revision.Feb 7 2022, 3:16 AM
This revision is now accepted and ready to land.Feb 7 2022, 3:16 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 7 2022, 3:16 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 7 2022, 3:16 AM
ashoat accepted this revision.Feb 7 2022, 9:45 AM
This revision is now accepted and ready to land.Feb 7 2022, 9:45 AM
• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:25 AM
• karol added a parent revision: D3082: [services] Backup - add Database Manager base.
• karol added a child revision: D3084: [services] Backup - Database - add Log Item.
• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:37 AM
• karol added a parent revision: D3080: [services] Backup - add AWS Tools.
• karol updated this revision to Diff 9363.Feb 8 2022, 1:43 AM

move diff in the structure

• karol edited the summary of this revision. (Show Details)Feb 8 2022, 1:46 AM
Harbormaster completed remote builds in B6607: Diff 9363.Feb 8 2022, 1:48 AM
Closed by commit rCOMM035dcc8fa6be: [services] Backup - Database - add Item (authored by • karol). · Explain WhyFeb 8 2022, 1:53 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM035dcc8fa6be: [services] Backup - Database - add Item.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
1 line
src/
DatabaseEntities/
26 lines

Diff 9371

View Options

services/backup/docker-server/contents/server/CMakeLists.txt

  • This file was copied to services/backup/src/Reactors/client/blob/BlobPutClientReactor.cpp.
#pragma once #pragma once
#include "ClientBidiReactorBase.h"
#include "Constants.h" #include "Constants.h"
#include "../_generated/blob.grpc.pb.h" #include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h" #include "../_generated/blob.pb.h"
#include "ClientBidiReactorBase.h"
#include <folly/MPMCQueue.h> #include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <condition_variable> #include <condition_variable>
#include <iostream>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobPutClientReactor class BlobPutClientReactor
Show All 22 Linespublic:
void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk); void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk);
std::unique_ptr<grpc::Status> prepareRequest( std::unique_ptr<grpc::Status> prepareRequest(
blob::PutRequest &request, blob::PutRequest &request,
std::shared_ptr<blob::PutResponse> previousResponse) override; std::shared_ptr<blob::PutResponse> previousResponse) override;
void doneCallback() override; void doneCallback() override;
grpc::Status getStatus() const; grpc::Status getStatus() const;
}; };
BlobPutClientReactor::BlobPutClientReactor(
const std::string &holder,
const std::string &hash,
std::condition_variable *terminationNotifier)
: holder(holder),
hash(hash),
dataChunks(folly::MPMCQueue<std::string>(100)),
terminationNotifier(terminationNotifier) {
}
void BlobPutClientReactor::scheduleSendingDataChunk(
std::unique_ptr<std::string> dataChunk) {
if (!this->dataChunks.write(std::move(*dataChunk))) {
throw std::runtime_error(
"Error scheduling sending a data chunk to send to the blob service");
}
}
std::unique_ptr<grpc::Status> BlobPutClientReactor::prepareRequest(
blob::PutRequest &request,
std::shared_ptr<blob::PutResponse> previousResponse) {
if (this->state == State::SEND_HOLDER) {
this->request.set_holder(this->holder);
this->state = State::SEND_HASH;
return nullptr;
}
if (this->state == State::SEND_HASH) {
request.set_blobhash(this->hash);
this->state = State::SEND_CHUNKS;
return nullptr;
}
if (previousResponse->dataexists()) {
return std::make_unique<grpc::Status>(grpc::Status::OK);
}
std::string dataChunk;
this->dataChunks.blockingRead(dataChunk);
if (dataChunk.empty()) {
return std::make_unique<grpc::Status>(grpc::Status::OK);
}
request.set_datachunk(dataChunk);
return nullptr;
}
void BlobPutClientReactor::doneCallback() {
this->terminationNotifier->notify_one();
}
grpc::Status BlobPutClientReactor::getStatus() const {
return this->status;
}
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

services/backup/docker-server/contents/server/src/DatabaseEntities/Item.h

  • This file was copied to services/backup/src/Reactors/client/blob/BlobPutClientReactor.cpp.
#pragma once #pragma once
#include "ClientBidiReactorBase.h"
#include "Constants.h" #include "Constants.h"
#include "../_generated/blob.grpc.pb.h" #include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h" #include "../_generated/blob.pb.h"
#include "ClientBidiReactorBase.h"
#include <folly/MPMCQueue.h> #include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <condition_variable> #include <condition_variable>
#include <iostream>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobPutClientReactor class BlobPutClientReactor
Show All 22 Linespublic:
void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk); void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk);
std::unique_ptr<grpc::Status> prepareRequest( std::unique_ptr<grpc::Status> prepareRequest(
blob::PutRequest &request, blob::PutRequest &request,
std::shared_ptr<blob::PutResponse> previousResponse) override; std::shared_ptr<blob::PutResponse> previousResponse) override;
void doneCallback() override; void doneCallback() override;
grpc::Status getStatus() const; grpc::Status getStatus() const;
}; };
BlobPutClientReactor::BlobPutClientReactor(
const std::string &holder,
const std::string &hash,
std::condition_variable *terminationNotifier)
: holder(holder),
hash(hash),
dataChunks(folly::MPMCQueue<std::string>(100)),
terminationNotifier(terminationNotifier) {
}
void BlobPutClientReactor::scheduleSendingDataChunk(
std::unique_ptr<std::string> dataChunk) {
if (!this->dataChunks.write(std::move(*dataChunk))) {
throw std::runtime_error(
"Error scheduling sending a data chunk to send to the blob service");
}
}
std::unique_ptr<grpc::Status> BlobPutClientReactor::prepareRequest(
blob::PutRequest &request,
std::shared_ptr<blob::PutResponse> previousResponse) {
if (this->state == State::SEND_HOLDER) {
this->request.set_holder(this->holder);
this->state = State::SEND_HASH;
return nullptr;
}
if (this->state == State::SEND_HASH) {
request.set_blobhash(this->hash);
this->state = State::SEND_CHUNKS;
return nullptr;
}
if (previousResponse->dataexists()) {
return std::make_unique<grpc::Status>(grpc::Status::OK);
}
std::string dataChunk;
this->dataChunks.blockingRead(dataChunk);
if (dataChunk.empty()) {
return std::make_unique<grpc::Status>(grpc::Status::OK);
}
request.set_datachunk(dataChunk);
return nullptr;
}
void BlobPutClientReactor::doneCallback() {
this->terminationNotifier->notify_one();
}
grpc::Status BlobPutClientReactor::getStatus() const {
return this->status;
}
} // namespace reactor } // namespace reactor
} // namespace network } // namespace network
} // namespace comm } // namespace comm