Page MenuHomePhabricator
Differential D3158

[services] Backup - Implementation structure
ClosedPublic
Actions

Authored by • karol on Feb 10 2022, 6:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 1:15 AM
Unknown Object (File)
Fri, Mar 7, 4:22 PM
Unknown Object (File)
Fri, Mar 7, 4:22 PM
Unknown Object (File)
Fri, Mar 7, 4:20 PM
Unknown Object (File)
Wed, Feb 26, 6:22 PM
Unknown Object (File)
Feb 4 2025, 9:23 AM
Unknown Object (File)
Jan 31 2025, 6:56 PM
Unknown Object (File)
Jan 28 2025, 7:07 AM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
varun
ashoat
• jim
Commits
rCOMMa91bed30ff24: [services] Backup - Implementation structure
Summary

Implementation structure based on the .proto file

Depends on D3087

Test Plan

Backup service builds successfully

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Feb 10 2022, 6:27 AM
Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 10 2022, 6:28 AM
Harbormaster completed remote builds in B6708: Diff 9518.Feb 10 2022, 6:32 AM
• karol requested review of this revision.Feb 10 2022, 6:32 AM
• karol edited the summary of this revision. (Show Details)Feb 10 2022, 6:34 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun.
• karol added a parent revision: D3087: [services] Backup - Database - add Backup Item.
• karol added a child revision: D3159: [services] Backup - Add Tools.
tomek accepted this revision.Feb 11 2022, 1:57 AM
This revision is now accepted and ready to land.Feb 11 2022, 1:57 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 11 2022, 1:57 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 11 2022, 1:57 AM
ashoat accepted this revision.Feb 13 2022, 7:58 PM
This revision is now accepted and ready to land.Feb 13 2022, 7:58 PM
ashoat added a reviewer: • jim.Feb 13 2022, 8:00 PM

Is grpc::ServerReaderWriter a blocking or non-blocking way to handle a bidi stream? (Or does it work either way?)

• karol added a comment.Feb 14 2022, 1:35 AM

For now, I'm using a sync API here. Once it's fully figured in the tunnelbroker so I can take a look, I'm going to refactor.

ashoat added a comment.Feb 14 2022, 8:11 PM

Okay, understood. Can you create a task to track, and set it as blocked on ENG-671 Bidirectional stream for Tunnelbroker?

• karol added a comment.Feb 15 2022, 1:21 AM

https://linear.app/comm/issue/ENG-768/use-async-api-in-backup

• karol updated this revision to Diff 9655.Feb 15 2022, 4:31 AM

update

• karol requested review of this revision.Feb 15 2022, 4:32 AM

updates after D3076

Harbormaster completed remote builds in B6816: Diff 9655.Feb 15 2022, 4:38 AM
ashoat accepted this revision.Feb 15 2022, 7:38 PM
This revision is now accepted and ready to land.Feb 15 2022, 7:38 PM
tomek accepted this revision.Feb 16 2022, 3:03 AM
Closed by commit rCOMMa91bed30ff24: [services] Backup - Implementation structure (authored by • karol). · Explain WhyMar 4 2022, 4:00 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMa91bed30ff24: [services] Backup - Implementation structure.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
40 lines
21 lines

Diff 10059

View Options

services/backup/docker-server/contents/server/src/BackupServiceImpl.h

#pragma once #pragma once
#include "../_generated/backup.grpc.pb.h" #include "../_generated/backup.grpc.pb.h"
#include "../_generated/backup.pb.h" #include "../_generated/backup.pb.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
namespace comm { namespace comm {
namespace network { namespace network {
class BackupServiceImpl final : public backup::BackupService::Service { class BackupServiceImpl final : public backup::BackupService::Service {
public: public:
BackupServiceImpl(); BackupServiceImpl();
virtual ~BackupServiceImpl(); virtual ~BackupServiceImpl();
/*
grpc::Status CreateNewBackup( grpc::Status CreateNewBackup(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReader<backup::CreateNewBackupRequest> *reader, grpc::ServerReaderWriter<
google::protobuf::Empty *response) override; backup::CreateNewBackupResponse,
backup::CreateNewBackupRequest> *stream) override;
grpc::Status SendLog( grpc::Status SendLog(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReader<backup::SendLogRequest> *reader, grpc::ServerReader<backup::SendLogRequest> *reader,
google::protobuf::Empty *response) override; google::protobuf::Empty *response) override;
grpc::Status PullBackupKey( grpc::Status RecoverBackupKey(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReaderWriter< grpc::ServerReaderWriter<
backup::PullBackupKeyResponse, backup::RecoverBackupKeyResponse,
backup::PullBackupKeyRequest> *stream) override; backup::RecoverBackupKeyRequest> *stream) override;
grpc::Status PullCompaction( grpc::Status PullBackup(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReaderWriter< grpc::ServerReaderWriter<
backup::PullCompactionResponse, backup::PullBackupResponse,
backup::PullCompactionRequest> *stream) override; backup::PullBackupRequest> *stream) override;
*/
}; };
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp

#include "BackupServiceImpl.h" #include "BackupServiceImpl.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
namespace comm { namespace comm {
namespace network { namespace network {
BackupServiceImpl::BackupServiceImpl() { BackupServiceImpl::BackupServiceImpl() {
Aws::InitAPI({}); Aws::InitAPI({});
} }
BackupServiceImpl::~BackupServiceImpl() { BackupServiceImpl::~BackupServiceImpl() {
Aws::ShutdownAPI({}); Aws::ShutdownAPI({});
} }
/*
grpc::Status BackupServiceImpl::CreateNewBackup( grpc::Status BackupServiceImpl::CreateNewBackup(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReader<backup::CreateNewBackupRequest> *reader, grpc::ServerReaderWriter<
google::protobuf::Empty *response) { backup::CreateNewBackupResponse,
backup::CreateNewBackupRequest> *stream) {
return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet"); return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet");
} }
grpc::Status BackupServiceImpl::SendLog( grpc::Status BackupServiceImpl::SendLog(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReader<backup::SendLogRequest> *reader, grpc::ServerReader<backup::SendLogRequest> *reader,
google::protobuf::Empty *response) { google::protobuf::Empty *response) {
return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet"); return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet");
} }
grpc::Status BackupServiceImpl::PullBackupKey( grpc::Status BackupServiceImpl::RecoverBackupKey(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReaderWriter< grpc::ServerReaderWriter<
backup::PullBackupKeyResponse, backup::RecoverBackupKeyResponse,
backup::PullBackupKeyRequest> *stream) { backup::RecoverBackupKeyRequest> *stream) {
return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet"); return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet");
} }
grpc::Status BackupServiceImpl::PullCompaction( grpc::Status BackupServiceImpl::PullBackup(
grpc::ServerContext *context, grpc::ServerContext *context,
grpc::ServerReaderWriter< grpc::ServerReaderWriter<
backup::PullCompactionResponse, backup::PullBackupResponse,
backup::PullCompactionRequest> *stream) { backup::PullBackupRequest> *stream) {
return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet"); return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented yet");
} }
*/
} // namespace network } // namespace network
} // namespace comm } // namespace comm