I spotted that there is a redundant glob in the blob's cmake.
Depends on D3198
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/blob/docker-server/contents/server/CMakeLists.txt | ||
|---|---|---|
| 37–41 | I think that SOURCE_CODE and DEV_SOURCE_CODE should be related, so if we have ./src/**/*.cpp in source code, shouldn't we keep ./src/**/*.dev.cpp? | |
| services/blob/docker-server/contents/server/CMakeLists.txt | ||
|---|---|---|
| 37–41 | Maybe that's the reason that this value is here. If you think we need this, we can always abandon the diff, just wanted to point out that it's redundant as no files matching this glob exist. | |
| services/blob/docker-server/contents/server/CMakeLists.txt | ||
|---|---|---|
| 37–41 | Up to you. It doesn't hurt to keep it and it will make it easier to add new dev code, but we can also delete this. | |