Paths

Table of Contentst

Differential D3159

[services] Backup - Add Tools
ClosedPublic
Actions

Authored by • karol on Feb 10 2022, 6:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 23, 5:48 PM

	Unknown Object (File)
	Tue, Apr 23, 5:48 PM

	Unknown Object (File)
	Tue, Apr 23, 5:48 PM

	Unknown Object (File)
	Tue, Apr 23, 5:44 PM

	Unknown Object (File)
	Mar 28 2024, 9:51 AM

	Unknown Object (File)
	Mar 27 2024, 8:50 AM

	Unknown Object (File)
	Mar 9 2024, 7:46 PM

	Unknown Object (File)
	Mar 3 2024, 2:30 PM

View All 85 Files

Subscribers

Details

Reviewers

tomek
• max
varun
ashoat
• jim

Commits

rCOMM073083fa62b2: [services] Backup - Add Tools

Summary

Adding Tools with getCurrentTimestamp which will be needed for creating backup items.

Depends on D3158

Test Plan

Backup service builds

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Feb 10 2022, 6:28 AM

Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 10 2022, 6:28 AM

Harbormaster completed remote builds in B6709: Diff 9519.Feb 10 2022, 6:35 AM

• karol requested review of this revision.Feb 10 2022, 6:35 AM

• karol edited the summary of this revision. (Show Details)Feb 10 2022, 6:35 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun.

• karol added a parent revision: D3158: [services] Backup - Implementation structure.

• karol added a child revision: D3160: [services] Backup - Add DB operations for Backup.Feb 10 2022, 6:38 AM

tomek accepted this revision.Feb 11 2022, 2:01 AM

This revision is now accepted and ready to land.Feb 11 2022, 2:01 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 11 2022, 2:01 AM

Herald added a subscriber: • benschac. · View Herald Transcript

This revision now requires review to proceed.Feb 11 2022, 2:01 AM

We have the exact same function in services/blob/docker-server/contents/server/src/Tools.cpp and services/tunnelbroker/docker-server/contents/server/src/Tools/Tools.cpp. I assume we're tracking fixing this in ENG-324... @karol-bisztyga, before landing can you add a comment there to make sure we remember to dedup all of the copy-pasted getCurrentTimestamp functions?

This revision is now accepted and ready to land.Feb 13 2022, 8:02 PM

This task will be resolved after I finish the backup service. I'm going to look at the services and try to exclude as many mutual items as possible to the "lib" space. I remember about this and keep it in mind.

Closed by commit rCOMM073083fa62b2: [services] Backup - Add Tools (authored by • karol). · Explain WhyMar 4 2022, 4:01 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM073083fa62b2: [services] Backup - Add Tools.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

11 lines

15 lines

Diff 10060

services/backup/docker-server/contents/server/src/Tools.h

Loading...

services/backup/docker-server/contents/server/src/Tools.cpp

Loading...