fix the "filled" icon, it's now message-filed-round and outline-key to key
Details
Details
- Reviewers
atul ashoat - Commits
- rCOMMf855c95576d1: [web] [fix] updated icons component
N/A this will break production because we don't have the new icon json yet. Nothing to test.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/SWMansionIcon.react.js | ||
|---|---|---|
| 30 ↗ | (On Diff #9933) | hasn't been used in the code base yet so nothing to change. |
Comment Actions
N/A this will break production because we don't have the new icon json yet
Is there a diff for this?
Ideally we wouldn't break production and we would have a single "atomic" commit that handles both the changes in this diff and the icomoon json stuff.
But if the icomoon JSON stuff is complicated, it's probably fine to separate that out into another diff. However, both diffs should be linked to each other in some way and we should be careful to at least land them "atomically."
Comment Actions
I should have added it to the stack. Just linked it.
Ideally we wouldn't break production and we would have a single "atomic" commit that handles both the changes in this diff and the icomoon json stuff.
I don't think changing the selection and app json are related to updating this diff. Can we talk about it? Happy to squash this diff with the JSON diff but it feels like they should be two different things.