Differential D3318

[web] [refactor] css thread tab css logic
ClosedPublic
Actions

Authored by • benschac on Mar 1 2022, 3:10 PM.

Tags

None

Referenced Files

	F3726840: D3318.id10236.diff
	Wed, Jan 8, 8:36 PM

	F3726839: D3318.id10045.diff
	Wed, Jan 8, 8:36 PM

	F3726838: D3318.id10007.diff
	Wed, Jan 8, 8:36 PM

	F3726827: D3318.id.diff
	Wed, Jan 8, 8:35 PM

	F3726786: D3318.diff
	Wed, Jan 8, 8:28 PM

	Unknown Object (File)
	Fri, Dec 27, 8:43 AM

	Unknown Object (File)
	Fri, Dec 27, 8:43 AM

	Unknown Object (File)
	Fri, Dec 27, 8:43 AM

Subscribers

Details

Reviewers

atul
ashoat

Commits

rCOMMde4f19571eea: [web] [refactor] css thread tab css logic

Summary

make css and react classnames a bit simpler. We didn't need the additional active and inactive classes and true css in the classname definition.

Screen Recording 2022-03-01 at 06.10.46 PM.gif (440×887 px, 320 KB)

Test Plan

Toggle chat tabs, functionality should remain the same

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 1 2022, 3:10 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 1 2022, 3:10 PM

• benschac edited the summary of this revision. (Show Details)Mar 1 2022, 3:11 PM

Harbormaster completed remote builds in B7100: Diff 10007.Mar 1 2022, 3:15 PM

• benschac requested review of this revision.Mar 1 2022, 3:15 PM

• benschac added a parent revision: D3316: [web] [fix] chat tab icon alignment and spacing.Mar 1 2022, 4:05 PM

• benschac removed a parent revision: D3316: [web] [fix] chat tab icon alignment and spacing.

• benschac added a parent revision: D3316: [web] [fix] chat tab icon alignment and spacing.

• benschac planned changes to this revision.Mar 3 2022, 9:06 AM

• benschac added inline comments.

web/chat/chat-tabs.css
39 ↗	(On Diff #10007)	I can remove this too.

remove unused css class

Harbormaster completed remote builds in B7134: Diff 10045.Mar 3 2022, 9:14 AM

css thread tab css logic

Nit: think we could probably have a more descriptive title for this diff

This revision is now accepted and ready to land.Mar 3 2022, 10:49 AM

atul added a reviewer: ashoat.Mar 3 2022, 10:49 AM

This revision now requires review to proceed.Mar 3 2022, 10:49 AM

ashoat accepted this revision.Mar 3 2022, 10:23 PM

ashoat added inline comments.

web/chat/chat-thread-tab.react.js
17–19 ↗	(On Diff #10045)	Personally, I think it is more readable if you avoid simultaneously using two ways to declare CSS classes, and stick to just one way

This revision is now accepted and ready to land.Mar 3 2022, 10:23 PM

Closed by commit rCOMMde4f19571eea: [web] [refactor] css thread tab css logic (authored by • benschac). · Explain WhyMar 9 2022, 10:43 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMde4f19571eea: [web] [refactor] css thread tab css logic.

Revision Contents
Changeset List

Path

Size

web/

chat/

7 lines

chat-thread-tab.react.js

4 lines

Diff 10236

web/chat/chat-tabs.css

Loading...

web/chat/chat-thread-tab.react.js

Loading...