Page MenuHomePhabricator
Differential D3300

[web] fix input icons to be the correct size
ClosedPublic
Actions

Authored by • benschac on Feb 28 2022, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 4:14 AM
Unknown Object (File)
Wed, Jan 8, 8:36 PM
Unknown Object (File)
Wed, Jan 8, 8:36 PM
Unknown Object (File)
Wed, Jan 8, 8:35 PM
Unknown Object (File)
Wed, Jan 8, 8:28 PM
Unknown Object (File)
Fri, Dec 27, 8:30 AM
Unknown Object (File)
Fri, Dec 27, 8:30 AM
Unknown Object (File)
Fri, Dec 27, 8:30 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
Commits
rCOMM005ec1e0e28e: [web] fix input icons to be the correct size
Summary

re-size the icons with padding,

before:

Image 2022-02-28 at 12.37.09 PM.jpg (138×2 px, 16 KB)

after:

Image 2022-02-28 at 12.36.50 PM.jpg (214×2 px, 33 KB)

Test Plan

check figma, make sure the icons are the correct size: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79456

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Feb 28 2022, 9:46 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 28 2022, 9:46 AM
• benschac edited the summary of this revision. (Show Details)Feb 28 2022, 9:47 AM
• benschac edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B7065: Diff 9955.Feb 28 2022, 9:51 AM
• benschac requested review of this revision.Feb 28 2022, 9:51 AM
ashoat mentioned this in D3299: [web] [fix] add icons with default paddings.Feb 28 2022, 6:20 PM
• benschac added a parent revision: D3299: [web] [fix] add icons with default paddings.Feb 28 2022, 6:35 PM
ashoat added a comment.Feb 28 2022, 7:49 PM

Does this diff cover all of the changes necessary following D3299 to reverse the padding regressions?

• benschac added a child revision: D3316: [web] [fix] chat tab icon alignment and spacing.Mar 1 2022, 2:21 PM
atul accepted this revision.Mar 2 2022, 8:13 AM

Looks much better, thanks for linking to the corresponding Figma component!

This revision is now accepted and ready to land.Mar 2 2022, 8:13 AM
• benschac added a comment.EditedMar 2 2022, 10:37 AM
In D3300#88916, @ashoat wrote:

Does this diff cover all of the changes necessary following D3299 to reverse the padding regressions?

It doesn't, I'm adding diffs to cover all the changes necessary. (they're all linked in the stack)

Closed by commit rCOMM005ec1e0e28e: [web] fix input icons to be the correct size (authored by • benschac). · Explain WhyMar 9 2022, 10:43 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM005ec1e0e28e: [web] fix input icons to be the correct size.

Revision Contents
Changeset List

PathSize
web/
chat/
4 lines

Diff 10235

View Options

web/chat/chat-input-bar.react.js

Loading...