Page MenuHomePhabricator
Differential D3330

[web] [fix] chevron size + plus spacing
ClosedPublic
Actions

Authored by • benschac on Mar 3 2022, 5:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 12:36 AM
Unknown Object (File)
Tue, Jan 7, 12:36 AM
Unknown Object (File)
Tue, Jan 7, 12:36 AM
Unknown Object (File)
Tue, Jan 7, 12:33 AM
Unknown Object (File)
Fri, Dec 27, 8:50 AM
Unknown Object (File)
Fri, Dec 27, 8:50 AM
Unknown Object (File)
Fri, Dec 27, 8:50 AM
Unknown Object (File)
Fri, Dec 27, 8:50 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM26e9aad6bb7a: [web] [fix] chevron size + plus spacing
Summary

adjust chevrons for padding, additonally, removed a wrapping div because it was causing an additonal 3-4px of bottom padding throwing off the alignment of the chevrons

before:

Image 2022-03-03 at 8.49.31 AM.jpg (412×1 px, 68 KB)

after:
Image 2022-03-03 at 8.48.18 AM.jpg (342×1 px, 42 KB)

Image 2022-03-03 at 9.13.55 AM.jpg (266×1 px, 47 KB)

Test Plan

match figma + centered. I have an unrelated diff addressing the color of the chevron being incorrect. https://phabricator.ashoat.com/D3327

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/?node-id=1170%3A77104

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 3 2022, 5:54 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 3 2022, 5:54 AM
• benschac edited the summary of this revision. (Show Details)Mar 3 2022, 5:56 AM
• benschac edited the test plan for this revision. (Show Details)
• benschac edited the summary of this revision. (Show Details)
• benschac edited the test plan for this revision. (Show Details)
• benschac added a parent revision: D3299: [web] [fix] add icons with default paddings.
Harbormaster completed remote builds in B7132: Diff 10043.Mar 3 2022, 6:00 AM
• benschac requested review of this revision.Mar 3 2022, 6:00 AM
• benschac edited the summary of this revision. (Show Details)Mar 3 2022, 6:14 AM
atul accepted this revision.Mar 3 2022, 9:18 AM
This revision is now accepted and ready to land.Mar 3 2022, 9:18 AM
atul added a reviewer: ashoat.Mar 3 2022, 9:18 AM
This revision now requires review to proceed.Mar 3 2022, 9:18 AM
ashoat accepted this revision.Mar 3 2022, 10:21 PM
This revision is now accepted and ready to land.Mar 3 2022, 10:21 PM
Closed by commit rCOMM26e9aad6bb7a: [web] [fix] chevron size + plus spacing (authored by • benschac). · Explain WhyMar 9 2022, 10:43 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM26e9aad6bb7a: [web] [fix] chevron size + plus spacing.

Revision Contents
Changeset List

Diff 10241

View Options

web/chat/chat-thread-ancestors.css

Loading...
View Options

web/chat/chat-thread-ancestors.react.js

Loading...