Page MenuHomePhabricator
Differential D3329

[web] [fix] update join button icon with padding, adjust layout
ClosedPublic
Actions

Authored by • benschac on Mar 3 2022, 5:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 8:07 PM
Unknown Object (File)
Wed, Nov 6, 7:03 PM
Unknown Object (File)
Wed, Nov 6, 7:03 PM
Unknown Object (File)
Wed, Nov 6, 11:35 AM
Unknown Object (File)
Sun, Nov 3, 1:21 PM
Unknown Object (File)
Sat, Nov 2, 8:21 AM
Unknown Object (File)
Sat, Nov 2, 8:21 AM
Unknown Object (File)
Sat, Nov 2, 8:21 AM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMb248558c337f: [web] [fix] update join button icon with padding, adjust layout
Summary

Update join button icon with correct size and layout now that icons have been updated

before:

Image 2022-03-03 at 8.18.14 AM.jpg (230×754 px, 15 KB)

after:

Image 2022-03-03 at 8.21.24 AM.jpg (174×538 px, 8 KB)

figma: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/?node-id=2448%3A4361

Test Plan

look at figma and make sure button matches the design.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Mar 3 2022, 5:27 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 3 2022, 5:27 AM
• benschac updated this revision to Diff 10042.Mar 3 2022, 5:28 AM

remove line

• benschac edited the summary of this revision. (Show Details)Mar 3 2022, 5:29 AM
• benschac added a parent revision: D3299: [web] [fix] add icons with default paddings.
Harbormaster completed remote builds in B7130: Diff 10041.Mar 3 2022, 5:32 AM
Harbormaster completed remote builds in B7131: Diff 10042.Mar 3 2022, 5:34 AM
• benschac requested review of this revision.Mar 3 2022, 5:34 AM
atul accepted this revision.Mar 3 2022, 10:54 AM

Personal opinion is the icon shouldn't be that much larger than the text... but the design is the design

This revision is now accepted and ready to land.Mar 3 2022, 10:54 AM
atul added a reviewer: ashoat.Mar 3 2022, 10:54 AM
This revision now requires review to proceed.Mar 3 2022, 10:54 AM
ashoat accepted this revision.Mar 3 2022, 10:23 PM
This revision is now accepted and ready to land.Mar 3 2022, 10:23 PM
Closed by commit rCOMMb248558c337f: [web] [fix] update join button icon with padding, adjust layout (authored by • benschac). · Explain WhyMar 9 2022, 10:43 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMb248558c337f: [web] [fix] update join button icon with padding, adjust layout.

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines
2 lines

Diff 10240

View Options

web/chat/chat-input-bar.css

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...