Paths

Table of Contentst

[web] Introduce settings section to NavInfo
ClosedPublic
Actions

Authored by tomek on Mar 4 2022, 8:02 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM1346e679edc6: [web] Introduce settings section to NavInfo

Summary

After this change it is possible to open /settings/account path - currently empty.
Depends on D3335
Depends on D3265

Test Plan

Open /settings/account path and check if empty page is rendered (with app and community switchers and correct background).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 4 2022, 8:02 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 4 2022, 8:02 AM

tomek added inline comments.Mar 4 2022, 8:04 AM

web/types/nav-types.js
11 ↗	(On Diff #10078)	Currently we have only one settings section
web/url-utils.js
104–109 ↗	(On Diff #10078)	This code is borrowed from D3265 which is a dependency of this diff

Harbormaster completed remote builds in B7152: Diff 10078.Mar 4 2022, 8:07 AM

tomek requested review of this revision.Mar 4 2022, 8:07 AM

tomek added a child revision: D3340: [web] Export navigation tab types.Mar 4 2022, 8:15 AM

atul accepted this revision.Mar 8 2022, 8:18 AM

atul added inline comments.

web/url-utils.js
61–62 ↗	(On Diff #10078)	Should we combine these into a single conditional? Or is it better to be symmetrical with what's above?

This revision is now accepted and ready to land.Mar 8 2022, 8:18 AM

tomek added inline comments.Mar 9 2022, 4:55 AM

web/url-utils.js
61–62 ↗	(On Diff #10078)	I think that keeping the symmetry doesn't bring a lot of value, so going to merge these

Merge if conditions

Harbormaster completed remote builds in B7251: Diff 10210.Mar 9 2022, 7:08 AM

Closed by commit rCOMM1346e679edc6: [web] Introduce settings section to NavInfo (authored by tomek). · Explain WhyMar 9 2022, 7:11 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1346e679edc6: [web] Introduce settings section to NavInfo.

Revision Contents
Changeset List

Path

Size

web/

types/

nav-types.js

3 lines

url-utils.js

15 lines

Diff 10212

View Options

web/types/nav-types.js