Navigate a user to account settings when an option is clicked.
Depends on D3342
Details
Details
Render the component instead of AppSwitcher. Open chat route - the My Account button shouldn't be highlighted. Click it - verify that the button is now highlighted and the the current route is settings/account.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/sidebar/settings-switcher.react.js | ||
|---|---|---|
| 16 ↗ | (On Diff #10085) | nit: settings section feels a bit too specific. Would section make more sense? |
| web/sidebar/settings-switcher.react.js | ||
|---|---|---|
| 16 ↗ | (On Diff #10085) | In this case I think that being specific makes sense, as we would like this field to only have values available for the settings. If we plan to introduce a new tab with sections, then we need to limit valid values for that tab, so either introduce a new field, or create more complicated nav structure { tab: 'settings', section: 'account' | ... } | { tab: anotherTab, section: '...' }But I'm not sure if that makes sense as we plan to use react navigation (or some other library) in near future |