[web] Render account settings when in right path
ClosedPublic
Actions

Authored by tomek on Mar 4 2022, 9:37 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM5b9e59f5dbdd: [web] Render account settings when in right path

Summary

Render account settings when in settings/account route. There's currently only one type of settings, but we still should check if the right one was selected (account)
Depends on D3324
Depends on D3344

Test Plan

Open settings/account URL and check if settings were rendered

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 4 2022, 9:37 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 4 2022, 9:37 AM

Harbormaster completed remote builds in B7161: Diff 10087.Mar 4 2022, 9:42 AM

tomek requested review of this revision.Mar 4 2022, 9:42 AM

atul accepted this revision.Mar 8 2022, 8:14 AM

This revision is now accepted and ready to land.Mar 8 2022, 8:14 AM

Closed by commit rCOMM5b9e59f5dbdd: [web] Render account settings when in right path (authored by tomek). · Explain WhyMar 11 2022, 4:05 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5b9e59f5dbdd: [web] Render account settings when in right path.

Revision Contents
Changeset List

Path

Size

web/

app.react.js

6 lines

Diff 10298

View Options

web/app.react.js

This file was added.

				// @flow

				import { processReportStoreOperations } from './report-store-ops.js';
				import {
				type ClientReportCreationRequest,
				reportTypes,
				} from '../types/report-types.js';

				const defaultReport = {
				type: reportTypes.MEDIA_MISSION,
				time: Date.now(),
				mediaMission: {
				steps: [],
				result: { success: true },
				totalTime: 0,
				userTime: 0,
				},
				};

				const defaultMockReportWeb = {
				platformDetails: { platform: 'web' },
				...defaultReport,
				};

				const defaultMockReportIos = {
				platformDetails: { platform: 'ios' },
				...defaultReport,
				};

				const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportWeb,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];

				const sortReports = (
				queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
				): $ReadOnlyArray<ClientReportCreationRequest> => {
				return [...queuedReports].sort(
				(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
				a.id.localeCompare(b.id),
				);
				};

				describe('processReportStoreOperations', () => {
				it('should return the original reports if no operations are processed', () => {
				const reportStoreOps = [];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(mockReports);
				});

				it('should replace the report with the given id', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportIos,
				id: '2',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportIos,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);

				expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
				});

				it('should handle an empty reports with replace operation', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportWeb,
				id: '1',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should remove reports with given ids', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should handle empty reports with remove_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});

				it('should remove all reports', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual([]);
				});

				it('should handle empty reports with remove_all_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});
				});

[web] Render account settings when in right pathClosedPublicActions