Page MenuHomePhabricator
Differential D3387

[web] Rename mostRecentReadThread to mostRecentlyReadThread
ClosedPublic
Actions

Authored by tomek on Mar 9 2022, 9:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 8:53 PM
Unknown Object (File)
Mon, Mar 31, 5:10 PM
Unknown Object (File)
Mon, Mar 31, 3:59 AM
Unknown Object (File)
Sun, Mar 30, 8:47 PM
Unknown Object (File)
Mar 8 2025, 1:28 AM
Unknown Object (File)
Mar 8 2025, 1:28 AM
Unknown Object (File)
Mar 8 2025, 1:28 AM
Unknown Object (File)
Mar 8 2025, 1:25 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• benschac
atul
• jacek
Commits
rCOMMd44fbb6a81ca: [web] Rename mostRecentReadThread to mostRecentlyReadThread
Summary

In D3341 we realized that it might be a good idea to rename mostRecentReadThread to mostRecentlyReadThread. This diff contains this rename with the corresponding selector rename to keep things consistent.
Depends on D3386

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
selectors/
10 lines
server/
src/
responders/
7 lines
web/
redux/
4 lines
sidebar/
8 lines

Diff 10291

View Options

lib/selectors/thread-selectors.js

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

server/src/responders/website-responders.js

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

web/redux/redux-setup.js

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

web/sidebar/app-switcher.react.js

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});