Paths

Table of Contentst

-
web/sidebar/
-
sidebar/
-
app-switcher.react.js
-
left-layout-aside.react.js

[web] Reintroduce AppSwitcher
ClosedPublic
Actions

Authored by tomek on Mar 4 2022, 8:13 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM70f06c8f49df: [web] Reintroduce AppSwitcher

Summary

This component renders a reusable component. The reusability will be achieved in next diffs by modifying NavigationPanel so that it receives navigation elements.
Depends on D3338

Test Plan

Check if AppSwitcher continues to work correctly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 4 2022, 8:13 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 4 2022, 8:13 AM

tomek added a child revision: D3340: [web] Export navigation tab types.Mar 4 2022, 8:15 AM

Harbormaster completed remote builds in B7155: Diff 10081.Mar 4 2022, 8:20 AM

tomek requested review of this revision.Mar 4 2022, 8:20 AM

• benschac accepted this revision.Mar 4 2022, 8:25 AM

This revision is now accepted and ready to land.Mar 4 2022, 8:25 AM

atul accepted this revision.Mar 8 2022, 8:25 AM

Closed by commit rCOMM70f06c8f49df: [web] Reintroduce AppSwitcher (authored by tomek). · Explain WhyMar 9 2022, 7:41 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM70f06c8f49df: [web] Reintroduce AppSwitcher.

Revision Contents
Changeset List

Path

Size

web/

sidebar/

app-switcher.react.js

11 lines

left-layout-aside.react.js

4 lines

Diff 10220

View Options

web/sidebar/app-switcher.react.js

This file was added.

				// @flow

				import { processReportStoreOperations } from './report-store-ops.js';
				import {
				type ClientReportCreationRequest,
				reportTypes,
				} from '../types/report-types.js';

				const defaultReport = {
				type: reportTypes.MEDIA_MISSION,
				time: Date.now(),
				mediaMission: {
				steps: [],
				result: { success: true },
				totalTime: 0,
				userTime: 0,
				},
				};

				const defaultMockReportWeb = {
				platformDetails: { platform: 'web' },
				...defaultReport,
				};

				const defaultMockReportIos = {
				platformDetails: { platform: 'ios' },
				...defaultReport,
				};

				const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportWeb,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];

				const sortReports = (
				queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
				): $ReadOnlyArray<ClientReportCreationRequest> => {
				return [...queuedReports].sort(
				(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
				a.id.localeCompare(b.id),
				);
				};

				describe('processReportStoreOperations', () => {
				it('should return the original reports if no operations are processed', () => {
				const reportStoreOps = [];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(mockReports);
				});

				it('should replace the report with the given id', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportIos,
				id: '2',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportIos,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);

				expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
				});

				it('should handle an empty reports with replace operation', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportWeb,
				id: '1',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should remove reports with given ids', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should handle empty reports with remove_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});

				it('should remove all reports', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual([]);
				});

				it('should handle empty reports with remove_all_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});
				});