Page MenuHomePhabricator

[server] Use baseRoutePath in getAppURLFactsFromRequestURL
ClosedPublic

Authored by ashoat on Mar 29 2022, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:58 PM
Unknown Object (File)
Sun, Nov 10, 12:12 AM
Unknown Object (File)
Sun, Nov 10, 12:11 AM
Unknown Object (File)
Sun, Nov 10, 12:06 AM
Unknown Object (File)
Fri, Nov 8, 7:42 PM
Unknown Object (File)
Tue, Nov 5, 1:24 AM
Unknown Object (File)
Oct 4 2024, 6:10 PM
Unknown Object (File)
Oct 4 2024, 6:10 PM

Details

Summary

baseRoutePath is the internal one, and req.url represents Node's internal path. basePath refers to the public (Apache) path.

Depends on D3552

Test Plan
  1. We tested the landing page, the SquadCal app, and the Comm app
  2. We made sure we tried configs where baseRoutePath !== basePath
  3. We also checked view-source to make sure things were set correctly
  4. We made sure there were no errors in the browser console
  5. We played around with the site, logging in and navigating and making sure things worked correctly
  6. We tried loading a specific URL for a specific chat directly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage