Page MenuHomePhabricator

Add amqp-cpp
ClosedPublic

Authored by jon on Apr 20 2022, 2:12 PM.
Tags
None
Referenced Files
F3380248: D3793.diff
Wed, Nov 27, 10:27 PM
Unknown Object (File)
Sun, Nov 24, 8:31 AM
Unknown Object (File)
Sun, Nov 24, 7:40 AM
Unknown Object (File)
Wed, Nov 20, 4:05 PM
Unknown Object (File)
Fri, Nov 15, 9:06 AM
Unknown Object (File)
Sun, Nov 10, 1:37 AM
Unknown Object (File)
Tue, Nov 5, 6:56 AM
Unknown Object (File)
Tue, Nov 5, 6:42 AM

Details

Summary

Add tunnelbroker's amqp-cpp dependency.

This isn't currently available in nixpkgs, so we need to package it locally.

Depends on D3784

Test Plan

nix build .#amqp-cpp

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 20 2022, 2:13 PM
Harbormaster failed remote builds in B8364: Diff 11676!

Accidental inclusion of unstaged files

Fix build with tcp extension

Remove accidental tunnelbroker mention

varun added a subscriber: varun.

think i should be a reviewer on this

ashoat added a reviewer: jim.
ashoat added a subscriber: jim.

Adding @geekbrother because AMQP pertains to Tunnelbroker, and adding @jimpo because there's some CMake stuff here

I think the package is available as libamqpcpp in nix packages. I'm not sure it's built with the -DAMQP-CPP_LINUX_TCP=ON.
But maybe it would be easier to use it and just pass the flags to the nix build, and nix rebuilds it. @jonringer-comm, what do you think?

max requested changes to this revision.May 2 2022, 4:10 AM
This revision now requires changes to proceed.May 2 2022, 4:10 AM

@geekbrother you're right, but it looks like it just uses the exported makeFile to build the project https://github.com/NixOS/nixpkgs/blob/634141959076a8ab69ca2cca0f266852256d79ee/pkgs/development/libraries/libamqpcpp/default.nix

The implications is that it doesn't export a cmake/amqpcppConfig.cmake

@jonringer-comm make sure to hit "Re-request review" in the dropdown at the bottom of the page, to make sure this diff goes back to @geekbrother's queue and he sees your response!

In D3793#108796, @jonringer-comm wrote:

@geekbrother you're right, but it looks like it just uses the exported makeFile to build the project https://github.com/NixOS/nixpkgs/blob/634141959076a8ab69ca2cca0f266852256d79ee/pkgs/development/libraries/libamqpcpp/default.nix

The implications is that it doesn't export a cmake/amqpcppConfig.cmake

That seems like a solution here. Thank you for the clarification @jonringer-comm !

This revision is now accepted and ready to land.May 5 2022, 10:58 AM
This revision was automatically updated to reflect the committed changes.