[Identity] Set max width to 80 characters
ClosedPublic
Actions

Authored by varun on May 4 2022, 6:32 PM.

Details

Reviewers

• karol
tomek
atul
• jim

Commits

rCOMM086389e20728: [Identity] Set max width to 80 characters

Summary

The rustfmt default is 100 characters, but we use 80 in the Comm codebase

Depends on D3853

Test Plan

Ran cargo build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.May 4 2022, 6:32 PM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 4 2022, 6:32 PM

Harbormaster completed remote builds in B8788: Diff 12236.May 4 2022, 6:37 PM

varun requested review of this revision.May 4 2022, 6:37 PM

varun added a child revision: D3921: [Identity] Implement database client method to get pake registration.May 4 2022, 8:40 PM

• karol accepted this revision.May 5 2022, 10:59 AM

• karol added a reviewer: • jim.

atul accepted this revision.May 5 2022, 11:33 AM

Resigning as reviewer b/c I don't condone 80 char line limits. :-P

This revision is now accepted and ready to land.May 5 2022, 3:35 PM

Closed by commit rCOMM086389e20728: [Identity] Set max width to 80 characters. · Explain WhyMay 10 2022, 7:20 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM086389e20728: [Identity] Set max width to 80 characters.

varun added a child revision: D4015: [services][identity] helper function to create primary key for DynamoDB.May 12 2022, 3:06 PM

varun removed a child revision: D3921: [Identity] Implement database client method to get pake registration.May 12 2022, 3:18 PM

Revision Contents
Changeset List

Path

Size

services/

identity/

rustfmt.toml

1 line

src/

config.rs

4 lines

opaque.rs

3 lines

service.rs

12 lines

Diff 12530

View Options

services/identity/rustfmt.toml

View Options

services/identity/src/config.rs

View Options

services/identity/src/opaque.rs

View Options

services/identity/src/service.rs

[Identity] Set max width to 80 charactersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12530

services/identity/rustfmt.toml

services/identity/src/config.rs

services/identity/src/opaque.rs

services/identity/src/service.rs

[Identity] Set max width to 80 characters
ClosedPublic
Actions

Revision Contents
Changeset List