Our DatabaseClient will fetch user tokens from DynamoDB. We need a struct to store the data pertaining to a token.
We use the chrono crate to handle date/time
Paths
| Differential D3945 Authored by varun on May 6 2022, 7:15 AM.
Details Summary Our DatabaseClient will fetch user tokens from DynamoDB. We need a struct to store the data pertaining to a token. We use the chrono crate to handle date/time Test Plan cargo build
Diff Detail
Event TimelineHerald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 6 2022, 7:15 AM2022-05-06 07:15:33 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.May 6 2022, 7:15 AM2022-05-06 07:15:41 (UTC-7) Harbormaster completed remote builds in B8857: Diff 12353.May 6 2022, 7:23 AM2022-05-06 07:23:28 (UTC-7) Harbormaster completed remote builds in B8878: Diff 12374.May 6 2022, 10:47 AM2022-05-06 10:47:53 (UTC-7) Comment Actions Why you don't put [services] prefix in your revisions' names for the identity service? I thought we had a convention that we put a prefix depending on the "module" we work on. So, for instance, [web], [server], [native]. [services] Is at the same level, [identity] is deeper one level. Is there a particular reason you do not do this here? Has this rule changed?
This revision now requires changes to proceed.May 9 2022, 2:51 AM2022-05-09 02:51:37 (UTC-7) Comment Actions
I have this pattern but I've actually never pushed it as a rule. The other day @jonringer-comm asked me if he should prefix his commit titles with [nix], so this is coming up in multiple places. Open to creating a rule for this but curious for other perspectives Comment Actions
I see. For me, personally, it would be handier because I set my herald rule to detect any revisions with [services] in their names. If you decide to user other naming then fine but I think it will be better for everybody to use one, consistent pattern. As a side note, maybe we could use tags? Comment Actions i'll use [services][identity] going forward. are herald rules case sensitive?
Comment Actions Rename Token to AccessToken to be more precise, make token field optional (to handle incomplete data in DynamoDB) Harbormaster completed remote builds in B9037: Diff 12580.May 12 2022, 8:35 AM2022-05-12 08:35:29 (UTC-7) Comment Actions back to you
This revision now requires changes to proceed.May 16 2022, 1:00 AM2022-05-16 01:00:41 (UTC-7) varun added inline comments.
Harbormaster completed remote builds in B9357: Diff 12964.May 19 2022, 11:27 AM2022-05-19 11:27:43 (UTC-7) This revision is now accepted and ready to land.May 24 2022, 12:21 PM2022-05-24 12:21:20 (UTC-7) Closed by commit rCOMM71d308d9abbc: [Identity] Add new types to handle tokens (authored by varun). · Explain WhyMay 25 2022, 10:58 AM2022-05-25 10:58:57 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 13124 services/identity/Cargo.lock
services/identity/Cargo.toml
services/identity/src/main.rs
services/identity/src/token.rs
|