[services][identity] helper function to finish PAKE login
AbandonedPublic
Actions

Authored by varun on May 27 2022, 12:05 PM.

Details

Reviewers

• jim
• karol
tomek

Summary

helper function handles deserialization of PAKE credential finalization bytes and returns a ServerLoginFinishResult containing the ServerLoginFinishResult

Depends on D4147

Test Plan

will test with later diff that calls helper function

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.May 27 2022, 12:05 PM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 27 2022, 12:05 PM

Harbormaster completed remote builds in B9515: Diff 13179.May 27 2022, 12:10 PM

varun requested review of this revision.May 27 2022, 12:10 PM

rebase

Harbormaster completed remote builds in B9521: Diff 13190.May 27 2022, 1:22 PM

• karol added 1 blocking reviewer(s): • jim.May 30 2022, 2:10 AM

• karol accepted this revision.May 30 2022, 2:17 AM

tomek accepted this revision.May 30 2022, 7:09 AM

tomek added inline comments.

services/identity/src/service.rs
3–6	We need to spend some time improving the formatting. E.g. multiple imports in one line would make blame hardly usable.

ashoat added inline comments.May 30 2022, 12:22 PM

services/identity/src/service.rs
3–6	Agree with this

varun added a child revision: D4182: [services][identity] helper function to handle sign-in with ethereum.Jun 1 2022, 2:22 PM

I don't think this helper function is necessary -- logic can be inlined. Feel free to argue otherwise.

This revision now requires changes to proceed.Jun 7 2022, 8:26 AM

varun abandoned this revision.Jun 13 2022, 5:40 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

service.rs

18 lines

Diff 13190

View Options

services/identity/src/service.rs

[services][identity] helper function to finish PAKE loginAbandonedPublicActions