Page MenuHomePhabricator

[Identity] Add new Error variant
ClosedPublic

Authored by varun on May 6 2022, 1:26 PM.
Tags
None
Referenced Files
F1774063: D3961.diff
Thu, May 16, 12:29 AM
Unknown Object (File)
Sat, May 11, 2:27 AM
Unknown Object (File)
Thu, May 9, 12:50 PM
Unknown Object (File)
Sat, May 4, 3:18 AM
Unknown Object (File)
Fri, May 3, 8:06 PM
Unknown Object (File)
Wed, May 1, 1:59 PM
Unknown Object (File)
Tue, Apr 23, 7:42 PM
Unknown Object (File)
Tue, Apr 23, 7:42 PM

Details

Summary

The Rusoto Error variant is too specific to handle both get and put errors. I'm therefore breaking it out into two variants, RusotoGet and RusotoPut. This will help us handle errors related to the put_item Rusoto method.

Depends on D3960

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.May 6 2022, 1:33 PM
This revision is now accepted and ready to land.May 9 2022, 3:25 AM

I'm not sure why this is in an "accepted" state. I hope it cannot be landed... After I accept, rust diffs should not be accepted, I know rust far too little to be decisive. Adding Jim as blocking.

This revision now requires review to proceed.May 9 2022, 4:53 AM
This revision is now accepted and ready to land.May 9 2022, 10:08 AM
This revision was automatically updated to reflect the committed changes.