Page MenuHomePhabricator

[Identity] Add new Error variant
ClosedPublic

Authored by varun on May 6 2022, 1:26 PM.
Tags
None
Referenced Files
F4098749: D3961.diff
Mon, Feb 17, 2:08 AM
Unknown Object (File)
Tue, Feb 4, 4:25 AM
Unknown Object (File)
Sun, Feb 2, 11:08 PM
Unknown Object (File)
Sat, Feb 1, 12:25 AM
Unknown Object (File)
Jan 17 2025, 6:21 PM
Unknown Object (File)
Jan 17 2025, 8:38 AM
Unknown Object (File)
Jan 14 2025, 12:28 PM
Unknown Object (File)
Jan 12 2025, 10:22 PM

Details

Summary

The Rusoto Error variant is too specific to handle both get and put errors. I'm therefore breaking it out into two variants, RusotoGet and RusotoPut. This will help us handle errors related to the put_item Rusoto method.

Depends on D3960

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Branch
varun/identity_service (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.May 6 2022, 1:33 PM
This revision is now accepted and ready to land.May 9 2022, 3:25 AM

I'm not sure why this is in an "accepted" state. I hope it cannot be landed... After I accept, rust diffs should not be accepted, I know rust far too little to be decisive. Adding Jim as blocking.

This revision now requires review to proceed.May 9 2022, 4:53 AM
This revision is now accepted and ready to land.May 9 2022, 10:08 AM
This revision was automatically updated to reflect the committed changes.