This function takes a partition key and optional sort key and returns a primary key for the DynamoDB client.
Depends on D3920
Details
Details
Unit tested
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks ok, but wouldn't it be better to add tests separately? I mean, in a different file or something?
| services/identity/src/database.rs | ||
|---|---|---|
| 47–48 ↗ | (On Diff #12578) | is it really a good practice to put tests right next to the functionality itself? Where does this come from? |
Comment Actions
Replied inline
| services/identity/src/database.rs | ||
|---|---|---|
| 47–48 ↗ | (On Diff #12578) | by convention, unit tests go in the same file as the function they are testing. https://doc.rust-lang.org/book/ch11-03-test-organization.html#unit-tests integration tests, on the other hand, should go in a separate tests directory. |
| services/identity/src/database.rs | ||
|---|---|---|
| 47–48 ↗ | (On Diff #12578) | Interesting! Thanks for clarifying! |
| services/identity/src/database.rs | ||
|---|---|---|
| 23 ↗ | (On Diff #12578) | If these are in an unordered HashMap, how will DynamoDB know which is the partition key and which is the sort key? |
Comment Actions
I think this would be better as two functions create_simple_primary_key(partition_key) and create_composite_primary_key(partition_key, sort_key). Terminology from https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.CoreComponents.html#HowItWorks.CoreComponents.PrimaryKey.
| services/identity/src/database.rs | ||
|---|---|---|
| 23 ↗ | (On Diff #12578) | Sorry, ignore this, I misunderstood what this does |