[Identity] Add new Error variant
ClosedPublic
Actions

Authored by varun on May 6 2022, 1:26 PM.

Details

Reviewers

• jim
• karol
tomek

Commits

rCOMM15980a381f92: [Identity] Add new Error variant

Summary

The Rusoto Error variant is too specific to handle both get and put errors. I'm therefore breaking it out into two variants, RusotoGet and RusotoPut. This will help us handle errors related to the put_item Rusoto method.

Depends on D3960

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.May 6 2022, 1:26 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 6 2022, 1:26 PM

varun added a child revision: D3962: [Identity] DatabaseClient method to put tokens in DDB.May 6 2022, 1:31 PM

Harbormaster completed remote builds in B8883: Diff 12386.May 6 2022, 1:33 PM

varun requested review of this revision.May 6 2022, 1:33 PM

• karol accepted this revision.May 9 2022, 3:25 AM

This revision is now accepted and ready to land.May 9 2022, 3:25 AM

I'm not sure why this is in an "accepted" state. I hope it cannot be landed... After I accept, rust diffs should not be accepted, I know rust far too little to be decisive. Adding Jim as blocking.

This revision now requires review to proceed.May 9 2022, 4:53 AM

• jim accepted this revision.May 9 2022, 10:08 AM

This revision is now accepted and ready to land.May 9 2022, 10:08 AM

Closed by commit rCOMM15980a381f92: [Identity] Add new Error variant (authored by varun). · Explain WhyMay 27 2022, 12:54 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM15980a381f92: [Identity] Add new Error variant.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

8 lines

Diff 13184

View Options

services/identity/src/database.rs

	Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines

	This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server.			This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server.

	# Debugging			# Debugging

	## React Developer Tools			## React Developer Tools

	- For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production.			- For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production.
	- For iOS and Android, TODO			- For iOS and Android, you can access the React Developer Tools by running `cd native && yarn react-devtools`. If you want to use it along with the JS debugger (see [Debugging JavaScript](#debugging-javascript)), you should open the JS debugger first, then open React Developer Tools, and finally refresh the app via the dev menu. More details on using React Developer Tools with React Native can be found [here](https://github.com/facebook/react/tree/main/packages/react-devtools#usage-with-react-native).

	## Redux Developer Tools			## Redux Developer Tools

	- For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools.			- For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools.
	- For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`.			- For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`.

	## Debugging JavaScript			## Debugging JavaScript

	- For web, you can just use your browser of choice’s dev tools.			- For web, you can just use your browser of choice’s dev tools.
	- For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression.			- For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression.

[Identity] Add new Error variantClosedPublicActions