Page MenuHomePhabricator

[services][identity] helper function to finish PAKE login
AbandonedPublic

Authored by varun on May 27 2022, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 9:49 PM
Unknown Object (File)
Thu, Oct 17, 10:45 AM
Unknown Object (File)
Thu, Oct 17, 10:45 AM
Unknown Object (File)
Thu, Oct 17, 10:45 AM
Unknown Object (File)
Thu, Oct 17, 10:44 AM
Unknown Object (File)
Sun, Oct 13, 8:13 PM
Unknown Object (File)
Sun, Oct 13, 8:13 PM
Unknown Object (File)
Sun, Oct 13, 8:12 PM

Details

Summary

helper function handles deserialization of PAKE credential finalization bytes and returns a ServerLoginFinishResult containing the ServerLoginFinishResult

Depends on D4147

Test Plan

will test with later diff that calls helper function

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek added inline comments.
services/identity/src/service.rs
3–6

We need to spend some time improving the formatting. E.g. multiple imports in one line would make blame hardly usable.

services/identity/src/service.rs
3–6

Agree with this

jim requested changes to this revision.Jun 7 2022, 8:26 AM

I don't think this helper function is necessary -- logic can be inlined. Feel free to argue otherwise.

This revision now requires changes to proceed.Jun 7 2022, 8:26 AM