Page MenuHomePhabricator

[keyserver] Make getSquadCalURLFacts return optional
ClosedPublic

Authored by ashoat on May 9 2022, 3:47 PM.
Tags
None
Referenced Files
F2207188: D3977.diff
Sun, Jul 7, 6:18 AM
Unknown Object (File)
Sat, Jul 6, 5:30 AM
Unknown Object (File)
Thu, Jul 4, 5:25 PM
Unknown Object (File)
Wed, Jul 3, 2:43 PM
Unknown Object (File)
Sun, Jun 30, 8:19 PM
Unknown Object (File)
Sun, Jun 30, 3:39 AM
Unknown Object (File)
Fri, Jun 21, 8:46 PM
Unknown Object (File)
Fri, Jun 21, 8:46 PM

Details

Summary

This makes it so squadcal_url.json isn't necessary, unless getAppURLFactsFromRequestURL gets called and commapp_url.json isn't defined. That should only happen if a request is received is received from Apache that doesn't match the baseRoutePath in commapp_url.json.

Depends on D3976

Test Plan

Make sure I can still use the keyserver without squadcal_url.json

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage