Page MenuHomePhabricator

[web] [fix] [ENG-536] disable input prop by default
ClosedPublic

Authored by benschac on May 13 2022, 7:28 AM.
Tags
None
Referenced Files
F3393388: D4035.diff
Sat, Nov 30, 1:36 PM
Unknown Object (File)
Sat, Nov 9, 3:19 PM
Unknown Object (File)
Sat, Nov 9, 3:18 PM
Unknown Object (File)
Sat, Nov 9, 3:18 PM
Unknown Object (File)
Sat, Nov 9, 6:19 AM
Unknown Object (File)
Fri, Nov 8, 2:57 AM
Unknown Object (File)
Oct 16 2024, 11:26 PM
Unknown Object (File)
Oct 7 2024, 10:25 PM

Details

Summary

From @palys-swm comment in D4023, input disabled prop should be set to false by default.

Test Plan

Flow shouldn't error, inputs fields work as intended and are enabled by default

image.png (1×910 px, 146 KB)

Grep the codebase, make sure there aren't disabled={true} props in the code base and that might disable input fields.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

As a test plan, please also check all the places where we use Input and haven't specify disabled value. (it looks like the prop was mandatory, so probably it is ok)

It might be also a good idea to delete, now extraneous, disabled={false} in every place it appears.

This revision is now accepted and ready to land.May 13 2022, 7:39 AM
In D4035#113263, @palys-swm wrote:

As a test plan, please also check all the places where we use Input and haven't specify disabled value. (it looks like the prop was mandatory, so probably it is ok)

Looked around the codebase. Looks like all of the spots with disabled have a value coming from a prop

image.png (1×1 px, 163 KB)

It might be also a good idea to delete, now extraneous, disabled={false} in every place it appears.

Yep, looked around, this was the only one.