[services] Blob - Fix unit tests
ClosedPublic
Actions

Authored by • karol on Jun 13 2022, 6:52 AM.

Details

Reviewers

tomek

Commits

rCOMMd8b88b6ab042: [services] Blob - Fix unit tests

Summary

Depends on D4216

Fixing bucket names in blob service unit tests. The assumption is that we're always going to run the unit tests in dev mode. So we can skip using some alternative bucket name like commapp-test

Test Plan

cd services
yarn run-unit-tests blob

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jun 13 2022, 6:52 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 13 2022, 6:52 AM

• karol edited the summary of this revision. (Show Details)Jun 13 2022, 7:24 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D4216: [services] Tests - Fix scripts.

• karol added a child revision: D4252: [services] Tests - Add backup test logic.Jun 13 2022, 8:01 AM

Harbormaster completed remote builds in B9728: Diff 13473.Jun 14 2022, 2:30 AM

• karol requested review of this revision.Jun 14 2022, 2:30 AM

tomek accepted this revision.Jun 20 2022, 4:32 AM

This revision is now accepted and ready to land.Jun 20 2022, 4:32 AM

How does the title of the diff correspond to the description and the code? Was there anything broken so that we need to fix it? Maybe use something less generic e.g. Use BLOB_BUCKET_NAME constant as blob bucket name?

It was broken as it didn't work with the current terraform configuration