Ran the code analysis tool in IDE which surfaced some misc CSS issues. I'll label each issue inline.
Depends on D4338
Paths
| Differential D4339 Authored by atul on Jun 22 2022, 7:13 PM.
Details Summary Ran the code analysis tool in IDE which surfaced some misc CSS issues. I'll label each issue inline. Depends on D4338 Test Plan NA, careful reading
Diff Detail
Event TimelineHerald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 22 2022, 7:13 PM2022-06-22 19:13:04 (UTC-7)
Harbormaster completed remote builds in B9902: Diff 13694.Jun 22 2022, 7:18 PM2022-06-22 19:18:01 (UTC-7) Harbormaster completed remote builds in B9903: Diff 13695.Jun 22 2022, 7:23 PM2022-06-22 19:23:01 (UTC-7) atul edited the summary of this revision. (Show Details)Jun 22 2022, 8:33 PM2022-06-22 20:33:59 (UTC-7) atul added a parent revision: D4338: [lib] Return `mergeNewMessages(...)` directly where possible in `reduceMessageStore(...)`. tomek added inline comments. This revision is now accepted and ready to land.Jun 23 2022, 4:56 AM2022-06-23 04:56:47 (UTC-7) • abosh added inline comments.
atul attached a referenced file: F82840: 44cbde.png. (Show Details)Jun 24 2022, 11:20 AM2022-06-24 11:20:42 (UTC-7) Comment Actions FYI, I can't see the images in this inline comment. I ran into a similar issue when reviewing another diff, so maybe this is an issue where images don't show up on inline comments. Edit: This revision was landed with ongoing or failed builds.Jun 24 2022, 11:22 AM2022-06-24 11:22:35 (UTC-7) Closed by commit rCOMM4bea17c16501: [web][landing] Fix miscellaneous CSS issues (authored by atul). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B9963: Diff 13780.Jun 24 2022, 11:25 AM2022-06-24 11:25:24 (UTC-7)
Revision Contents
Diff 13781 landing/info-block.css
landing/subscription-form.css
web/components/menu.css
web/theme.css
|