Page MenuHomePhabricator
Differential D4343

[web] [landing] Omit units for 0 values in CSS
ClosedPublic
Actions

Authored by • abosh on Jun 23 2022, 8:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 8:06 AM
Unknown Object (File)
Fri, Apr 18, 3:51 AM
Unknown Object (File)
Fri, Apr 18, 3:39 AM
Unknown Object (File)
Thu, Apr 17, 1:32 PM
Unknown Object (File)
Tue, Apr 8, 5:52 PM
Unknown Object (File)
Tue, Apr 8, 5:52 PM
Unknown Object (File)
Tue, Apr 8, 5:52 PM
Unknown Object (File)
Tue, Apr 8, 5:52 PM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
atul
tomek
Commits
rCOMM746063b42798: [web] [landing] Omit units for 0 values in CSS
Summary

The units for 0 values in CSS are redundant. This is a quick no-op change that makes the code more concise and readable as the unitless 0 is distinguished from hard-set values with units.

Read more: https://stackoverflow.com/q/7923042/13079675

This technically depends on D4339 since both diffs modify landing/subscription-form.css, but I can resolve that merge conflict quickly and easily.

Test Plan

Find-and-replace + close reading. 0px == 0 in CSS, so there are no style changes that can occur as a result of this.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
landing/
12 lines
web/
apps/
2 lines
calendar/
2 lines
2 lines
chat/
6 lines
2 lines
media/
6 lines
modals/
history/
2 lines
2 lines

Diff 13713

View Options

landing/subscription-form.css

#pragma once #pragma once
#include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h" #include "../_generated/blob.pb.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <iostream> #include <iostream>
Show All 18 Linespublic:
void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) { void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) {
if (putReactor == nullptr) { if (putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"put reactor is being used but has not been initialized"); "put reactor is being used but has not been initialized");
} }
this->stub->async()->Put(&putReactor->context, &(*putReactor)); this->stub->async()->Put(&putReactor->context, &(*putReactor));
putReactor->nextWrite(); putReactor->nextWrite();
} }
// void get(const std::string &holder);
void get(std::shared_ptr<reactor::BlobGetClientReactor> getReactor) {
if (getReactor == nullptr) {
throw std::runtime_error(
"get reactor is being used but has not been initialized");
}
this->stub->async()->Get(
&getReactor->context, &getReactor->request, &(*getReactor));
getReactor->start();
}
// void remove(const std::string &holder); // void remove(const std::string &holder);
}; };
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/apps/apps.css

#pragma once #pragma once
#include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h" #include "../_generated/blob.pb.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <iostream> #include <iostream>
Show All 18 Linespublic:
void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) { void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) {
if (putReactor == nullptr) { if (putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"put reactor is being used but has not been initialized"); "put reactor is being used but has not been initialized");
} }
this->stub->async()->Put(&putReactor->context, &(*putReactor)); this->stub->async()->Put(&putReactor->context, &(*putReactor));
putReactor->nextWrite(); putReactor->nextWrite();
} }
// void get(const std::string &holder);
void get(std::shared_ptr<reactor::BlobGetClientReactor> getReactor) {
if (getReactor == nullptr) {
throw std::runtime_error(
"get reactor is being used but has not been initialized");
}
this->stub->async()->Get(
&getReactor->context, &getReactor->request, &(*getReactor));
getReactor->start();
}
// void remove(const std::string &holder); // void remove(const std::string &holder);
}; };
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/calendar/calendar.css

#pragma once #pragma once
#include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h" #include "../_generated/blob.pb.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <iostream> #include <iostream>
Show All 18 Linespublic:
void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) { void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) {
if (putReactor == nullptr) { if (putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"put reactor is being used but has not been initialized"); "put reactor is being used but has not been initialized");
} }
this->stub->async()->Put(&putReactor->context, &(*putReactor)); this->stub->async()->Put(&putReactor->context, &(*putReactor));
putReactor->nextWrite(); putReactor->nextWrite();
} }
// void get(const std::string &holder);
void get(std::shared_ptr<reactor::BlobGetClientReactor> getReactor) {
if (getReactor == nullptr) {
throw std::runtime_error(
"get reactor is being used but has not been initialized");
}
this->stub->async()->Get(
&getReactor->context, &getReactor->request, &(*getReactor));
getReactor->start();
}
// void remove(const std::string &holder); // void remove(const std::string &holder);
}; };
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/calendar/thread-picker.css

#pragma once #pragma once
#include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h" #include "../_generated/blob.pb.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <iostream> #include <iostream>
Show All 18 Linespublic:
void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) { void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) {
if (putReactor == nullptr) { if (putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"put reactor is being used but has not been initialized"); "put reactor is being used but has not been initialized");
} }
this->stub->async()->Put(&putReactor->context, &(*putReactor)); this->stub->async()->Put(&putReactor->context, &(*putReactor));
putReactor->nextWrite(); putReactor->nextWrite();
} }
// void get(const std::string &holder);
void get(std::shared_ptr<reactor::BlobGetClientReactor> getReactor) {
if (getReactor == nullptr) {
throw std::runtime_error(
"get reactor is being used but has not been initialized");
}
this->stub->async()->Get(
&getReactor->context, &getReactor->request, &(*getReactor));
getReactor->start();
}
// void remove(const std::string &holder); // void remove(const std::string &holder);
}; };
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/chat/chat-thread-ancestors.css

#pragma once #pragma once
#include "BlobGetClientReactor.h"
#include "BlobPutClientReactor.h" #include "BlobPutClientReactor.h"
#include "../_generated/blob.grpc.pb.h" #include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h" #include "../_generated/blob.pb.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <iostream> #include <iostream>
Show All 18 Linespublic:
void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) { void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) {
if (putReactor == nullptr) { if (putReactor == nullptr) {
throw std::runtime_error( throw std::runtime_error(
"put reactor is being used but has not been initialized"); "put reactor is being used but has not been initialized");
} }
this->stub->async()->Put(&putReactor->context, &(*putReactor)); this->stub->async()->Put(&putReactor->context, &(*putReactor));
putReactor->nextWrite(); putReactor->nextWrite();
} }
// void get(const std::string &holder);
void get(std::shared_ptr<reactor::BlobGetClientReactor> getReactor) {
if (getReactor == nullptr) {
throw std::runtime_error(
"get reactor is being used but has not been initialized");
}
this->stub->async()->Get(
&getReactor->context, &getReactor->request, &(*getReactor));
getReactor->start();
}
// void remove(const std::string &holder); // void remove(const std::string &holder);
}; };
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

web/chat/chat-thread-list.css

Loading...
View Options

web/media/media.css

Loading...
View Options

web/modals/history/history.css

Loading...
View Options

web/modals/modal.css

Loading...