Page MenuHomePhabricator
Differential D4383

Extend interface for elementary file operations with encryption-decryption layer by Obj-C style private interface for encryption end decryption
ClosedPublic
Actions

Authored by marcin on Jun 28 2022, 8:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 12:19 PM
Unknown Object (File)
Wed, Mar 26, 2:52 PM
Unknown Object (File)
Fri, Mar 21, 11:44 AM
Unknown Object (File)
Wed, Mar 19, 9:34 PM
Unknown Object (File)
Wed, Mar 19, 6:52 PM
Unknown Object (File)
Tue, Mar 18, 12:02 AM
Unknown Object (File)
Sun, Mar 16, 8:37 AM
Unknown Object (File)
Thu, Mar 13, 8:19 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
• karol
tomek
varun
Commits
rCOMMbd1697a92bd4: Extend interface for elementary file operations with encryption-decryption…
Summary

Define additional private methods to encrypt and decrypt messages before the are written to or read from flat file storage

Test Plan

No test plan

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 28 2022, 8:34 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 28 2022, 8:34 AM
Harbormaster completed remote builds in B10058: Diff 13907.Jun 28 2022, 8:44 AM
marcin requested review of this revision.Jun 28 2022, 8:44 AM
marcin added a parent revision: D4382: Define interface for elementary file operations: atomic write, append, read and atomic truncation with encryption-decryption layer based on encryption key in CommSecureStore.Jun 29 2022, 2:35 AM
marcin added a child revision: D4384: Implement encryption-decryption layer for elementary file operations.
tomek accepted this revision.Jun 29 2022, 7:22 AM
This revision is now accepted and ready to land.Jun 29 2022, 7:22 AM
marcin updated this revision to Diff 14064.Jul 1 2022, 2:02 AM

Introduce files to project.pbxproj

Harbormaster completed remote builds in B10186: Diff 14064.Jul 1 2022, 2:14 AM
marcin updated this revision to Diff 14151.Jul 5 2022, 3:20 AM

Rebase

Harbormaster failed remote builds in B10259: Diff 14151!Jul 5 2022, 3:20 AM
marcin updated this revision to Diff 14162.Jul 5 2022, 3:30 AM

Rebase master

Harbormaster completed remote builds in B10270: Diff 14162.Jul 5 2022, 4:33 AM
marcin updated this revision to Diff 14222.Jul 6 2022, 4:34 AM

Change signature of decryption operation to work with strings

Harbormaster completed remote builds in B10316: Diff 14222.Jul 6 2022, 4:46 AM
marcin updated this revision to Diff 14270.Jul 7 2022, 7:06 AM

Rename Temporal to Temporary

Harbormaster completed remote builds in B10362: Diff 14270.Jul 7 2022, 7:31 AM
marcin updated this revision to Diff 14464.Jul 14 2022, 4:48 AM

Rebase

Harbormaster completed remote builds in B10515: Diff 14464.Jul 14 2022, 5:03 AM
Closed by commit rCOMMbd1697a92bd4: Extend interface for elementary file operations with encryption-decryption… (authored by marcin). · Explain WhyJul 14 2022, 5:10 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbd1697a92bd4: Extend interface for elementary file operations with encryption-decryption….

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
6 lines
Comm/
TemporaryMessageStorage/
12 lines

Diff 14464

View Options

native/ios/Comm.xcodeproj/project.pbxproj

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { ParserRules } from './markdown.js'; import type { ParserRules } from './markdown.js';
import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js'; import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js';
import { relationshipBlockedInEitherDirection } from './relationship-utils.js'; import { relationshipBlockedInEitherDirection } from './relationship-utils.js';
import { import {
createPendingThread, createPendingThread,
getSingleOtherUser, getSingleOtherUser,
extractMentionedMembers, extractMentionedMembers,
useThreadHasPermission, useThreadHasPermission,
userIsMember, userIsMember,
} from './thread-utils.js'; } from './thread-utils.js';
import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js'; import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js';
import { chatMessageItemEngagementTargetMessageInfo } from '../shared/chat-message-item-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import type { import type {
RobotextMessageInfo, RobotextMessageInfo,
ComposableMessageInfo, ComposableMessageInfo,
} from '../types/message-types.js'; } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
▲ Show 20 Lines • Show All 200 Lines • ▼ Show 20 Lines return (
!relationshipBlockedInEitherDirection(messageCreatorRelationship) !relationshipBlockedInEitherDirection(messageCreatorRelationship)
); );
} }
function useSidebarExistsOrCanBeCreated( function useSidebarExistsOrCanBeCreated(
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
messageItem: ChatMessageInfoItem, messageItem: ChatMessageInfoItem,
): boolean { ): boolean {
const engagementTargetMessageInfo =
chatMessageItemEngagementTargetMessageInfo(messageItem);
const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage( const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage(
threadInfo, threadInfo,
messageItem.messageInfo, engagementTargetMessageInfo,
); );
return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage; return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage;
} }
export { export {
createUnresolvedPendingSidebar, createUnresolvedPendingSidebar,
createPendingSidebar, createPendingSidebar,
useCanCreateSidebarFromMessage, useCanCreateSidebarFromMessage,
useSidebarExistsOrCanBeCreated, useSidebarExistsOrCanBeCreated,
}; };
View Options

native/ios/Comm/TemporaryMessageStorage/EncryptedFileUtils.mm

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { ParserRules } from './markdown.js'; import type { ParserRules } from './markdown.js';
import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js'; import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js';
import { relationshipBlockedInEitherDirection } from './relationship-utils.js'; import { relationshipBlockedInEitherDirection } from './relationship-utils.js';
import { import {
createPendingThread, createPendingThread,
getSingleOtherUser, getSingleOtherUser,
extractMentionedMembers, extractMentionedMembers,
useThreadHasPermission, useThreadHasPermission,
userIsMember, userIsMember,
} from './thread-utils.js'; } from './thread-utils.js';
import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js'; import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js';
import { chatMessageItemEngagementTargetMessageInfo } from '../shared/chat-message-item-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import type { import type {
RobotextMessageInfo, RobotextMessageInfo,
ComposableMessageInfo, ComposableMessageInfo,
} from '../types/message-types.js'; } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
▲ Show 20 Lines • Show All 200 Lines • ▼ Show 20 Lines return (
!relationshipBlockedInEitherDirection(messageCreatorRelationship) !relationshipBlockedInEitherDirection(messageCreatorRelationship)
); );
} }
function useSidebarExistsOrCanBeCreated( function useSidebarExistsOrCanBeCreated(
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
messageItem: ChatMessageInfoItem, messageItem: ChatMessageInfoItem,
): boolean { ): boolean {
const engagementTargetMessageInfo =
chatMessageItemEngagementTargetMessageInfo(messageItem);
const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage( const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage(
threadInfo, threadInfo,
messageItem.messageInfo, engagementTargetMessageInfo,
); );
return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage; return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage;
} }
export { export {
createUnresolvedPendingSidebar, createUnresolvedPendingSidebar,
createPendingSidebar, createPendingSidebar,
useCanCreateSidebarFromMessage, useCanCreateSidebarFromMessage,
useSidebarExistsOrCanBeCreated, useSidebarExistsOrCanBeCreated,
}; };