Page MenuHomePhabricator
Differential D4384

Implement encryption-decryption layer for elementary file operations
ClosedPublic
Actions

Authored by marcin on Jun 28 2022, 8:36 AM.
Tags
None
Referenced Files
F3150759: D4384.diff
Tue, Nov 5, 12:24 AM
Unknown Object (File)
Sat, Nov 2, 4:26 AM
Unknown Object (File)
Sat, Oct 26, 2:50 AM
Unknown Object (File)
Thu, Oct 24, 11:05 PM
Unknown Object (File)
Wed, Oct 23, 7:15 PM
Unknown Object (File)
Mon, Oct 7, 12:26 AM
Unknown Object (File)
Mon, Oct 7, 12:25 AM
Unknown Object (File)
Oct 5 2024, 1:51 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
varun
• karol
Commits
rCOMM99894c91276b: Implement encryption-decryption layer for elementary file operations
Summary

Implements encryption-decryption layer for flat-file message store operations.

Test Plan

Modify AppDelegate so that on AppLaunch it encrypts and decrypts some text then assert they are equal.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 28 2022, 8:36 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 28 2022, 8:36 AM
Harbormaster completed remote builds in B10059: Diff 13908.Jun 28 2022, 8:47 AM
marcin requested review of this revision.Jun 28 2022, 8:47 AM
marcin added a parent revision: D4383: Extend interface for elementary file operations with encryption-decryption layer by Obj-C style private interface for encryption end decryption.Jun 29 2022, 2:35 AM
marcin added a child revision: D4385: Implement elementary file operations with encryption-decryption layer.
• karol added a comment.Jun 29 2022, 6:41 AM

your diffs miss the prefixes in their titles ([native])

native/ios/Comm/TemporalMessageStorage/EncryptedFileUtils.mm
75 ↗(On Diff #13908)

newline

tomek accepted this revision.Jun 29 2022, 8:04 AM
tomek added inline comments.
native/ios/Comm/TemporalMessageStorage/EncryptedFileUtils.mm
16–17 ↗(On Diff #13908)

Shouldn't we use self?

61 ↗(On Diff #13908)

Why do we need to modify the length?

This revision is now accepted and ready to land.Jun 29 2022, 8:04 AM
marcin added inline comments.Jun 30 2022, 6:34 AM
native/ios/Comm/TemporalMessageStorage/EncryptedFileUtils.mm
16–17 ↗(On Diff #13908)

All methods in this class are static (or "type methods" speaking more Obj-C language), so we can't use self here. I decided to go with type methods since I don't see how to naturally introduce state for this class.

tomek added inline comments.Jun 30 2022, 6:45 AM
native/ios/Comm/TemporalMessageStorage/EncryptedFileUtils.mm
16–17 ↗(On Diff #13908)

Ok, that makes sense!

marcin updated this revision to Diff 14065.Jul 1 2022, 2:02 AM

Introduce files to project.pbxproj

Harbormaster completed remote builds in B10187: Diff 14065.Jul 1 2022, 2:14 AM
marcin edited the test plan for this revision. (Show Details)Jul 1 2022, 2:51 AM
marcin added inline comments.Jul 1 2022, 8:17 AM
native/ios/Comm/TemporalMessageStorage/EncryptedFileUtils.mm
61 ↗(On Diff #13908)

Length of the buffer might change during encryption/decryption process

marcin updated this revision to Diff 14152.Jul 5 2022, 3:21 AM

Manually implement padding. Switch to AES algorithm with ECB mode

Harbormaster failed remote builds in B10260: Diff 14152!Jul 5 2022, 3:21 AM
marcin updated this revision to Diff 14163.Jul 5 2022, 3:30 AM

Rebase master

Harbormaster completed remote builds in B10271: Diff 14163.Jul 5 2022, 4:39 AM
marcin updated this revision to Diff 14223.Jul 6 2022, 4:35 AM

Change encryption algorithm to AES CBC, decrypt each message separately

Harbormaster completed remote builds in B10317: Diff 14223.Jul 6 2022, 4:49 AM
marcin updated this revision to Diff 14271.Jul 7 2022, 7:07 AM

Rename Temporal to Temporary

marcin updated this revision to Diff 14272.Jul 7 2022, 7:08 AM

Rename Temporal to Temporary

Harbormaster completed remote builds in B10363: Diff 14271.Jul 7 2022, 7:38 AM
Harbormaster completed remote builds in B10364: Diff 14272.Jul 7 2022, 7:45 AM
marcin updated this revision to Diff 14465.Jul 14 2022, 4:49 AM

Rebase

Harbormaster completed remote builds in B10516: Diff 14465.Jul 14 2022, 5:08 AM
Closed by commit rCOMM99894c91276b: Implement encryption-decryption layer for elementary file operations (authored by marcin). · Explain WhyJul 14 2022, 5:10 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM99894c91276b: Implement encryption-decryption layer for elementary file operations.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
TemporalMessageStorage/
73 lines

Diff 14163

View Options

native/ios/Comm/TemporalMessageStorage/EncryptedFileUtils.mm

Loading...