[services] Tests - Use lazy static instead of functions
ClosedPublic
Actions

Authored by • karol on Jul 1 2022, 6:14 AM.

Details

Reviewers

tomek
ashoat

Commits

rCOMM4d5e74a9f80d: [services] Tests - Use lazy static instead of functions

Summary

Depends on D4413

Suggested in https://phab.comm.dev/D4325#124852
We can use Rust's lazy_static instead of functions to have static variables calculated in the runtime

Test Plan

services tests work as before

Diff Detail

Repository

rCOMM Comm

Branch

services-test

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jul 1 2022, 6:14 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 1 2022, 6:14 AM

• karol mentioned this in D4325: [services] Tests - Backup - Add dynamoDB item size limit.Jul 1 2022, 6:14 AM

Harbormaster completed remote builds in B10206: Diff 14084.Jul 1 2022, 6:26 AM

• karol requested review of this revision.Jul 1 2022, 6:26 AM

tomek accepted this revision.Jul 1 2022, 7:35 AM

tomek added a reviewer: ashoat.

ashoat accepted this revision.Jul 2 2022, 6:41 PM

This revision is now accepted and ready to land.Jul 2 2022, 6:41 PM

• karol added a child revision: D4437: [services] Add reset local cloud command.Jul 5 2022, 12:52 AM

Closed by commit rCOMM4d5e74a9f80d: [services] Tests - Use lazy static instead of functions (authored by • karol). · Explain WhyJul 8 2022, 2:31 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM4d5e74a9f80d: [services] Tests - Use lazy static instead of functions.

ashoat added inline comments.Jul 8 2022, 12:55 PM

services/commtest/tests/lib/tools.rs
28–29 ↗	(On Diff #14352)	It doesn't seem like this was formatted properly, despite coming after D4413 ("run cargo fmt") in the stack. Creating a Linear task ENG-1368 for @karol-bisztyga to resolve this