[services] Tunnelbroker - Switching to use composite key in a messages table in Terraform
ClosedPublic
Actions

Authored by • max on Jul 7 2022, 6:37 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMM43cc1b683217: [services] Tunnelbroker - Switching to use composite key in a messages table in…

Summary

To avoid possible message UUID collision and speedup batch messages deletion we should switch to using the composite key for the tunnelbroker-messages table which will consist of messagesID as a Sort Key and toDeviceID as a Partition key.

This diff is a part of the stack and introduces changes for Terraform.

Linear task: ENG-1362

Test Plan

These changes should be tested at the D4475 diff. The current messageItem related tests at services/tunnelbroker/test/DatabaseManagerTest.cpp should not fail including:

PutAndFoundMessageItemsStaticDataIsSame
PutAndFoundMessageItemsGeneratedDataIsSame
PutAndFoundByReceiverMessageItemsDataIsSame

Diff Detail

Repository

rCOMM Comm

Branch

switch-to-composite-messages-key

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jul 7 2022, 6:37 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 7 2022, 6:37 AM

• max edited the summary of this revision. (Show Details)Jul 7 2022, 6:38 AM

• max retitled this revision from [services] Tunnelbroker - Switching to use composite key in a messages table inTerraform to [services] Tunnelbroker - Switching to use composite key in a messages table in Terraform.Jul 7 2022, 6:48 AM

Harbormaster completed remote builds in B10356: Diff 14264.Jul 7 2022, 6:50 AM

• max edited the summary of this revision. (Show Details)Jul 7 2022, 6:56 AM

• max added a child revision: D4475: [services] Tunnelbroker - Switching to use composite key in a messageItem entity.

• max edited the test plan for this revision. (Show Details)Jul 7 2022, 7:03 AM

• max added reviewers: • karol, tomek.

• max published this revision for review.Jul 7 2022, 7:06 AM

• max added a child revision: D4476: [services] Tunnelbroker - Database function that removes messages by a batch using messageIDs and receiver DeviceID..Jul 7 2022, 7:46 AM

• max added a child revision: D4478: [services] Tunnelbroker - Add test for `removeMessageItemsByIDsForDeviceID` database function.Jul 7 2022, 8:37 AM

tomek accepted this revision.Jul 8 2022, 2:24 AM

tomek added 1 blocking reviewer(s): • karol.

Shouldn't we also modify the entity files? I'd put the fields in this file (especially in the constructor) in the correct order which would be:

partition key
sort key
the rest of the fields

So, for the messages this would be:

toDeviceID
messageID
fromDeviceID
payload
...

What do you think? Sorry for requesting changes but I wanted to push it to your queue.

This revision now requires changes to proceed.Jul 11 2022, 3:07 AM

In D4473#127995, @karol-bisztyga wrote:

Shouldn't we also modify the entity files? I'd put the fields in this file (especially in the constructor) in the correct order which would be:

partition key

sort key

the rest of the fields

So, for the messages this would be:

toDeviceID

messageID

fromDeviceID

payload

...

What do you think? Sorry for requesting changes but I wanted to push it to your queue.