Page MenuHomePhabricator
Differential D4564

[Nix] Add cmake-format to dev shell
ClosedPublic
Actions

Authored by • jon on Jul 18 2022, 2:52 PM.
Tags
None
Referenced Files
F3361778: D4564.diff
Sun, Nov 24, 7:24 PM
Unknown Object (File)
Sat, Nov 23, 6:08 AM
Unknown Object (File)
Fri, Nov 22, 7:15 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
Unknown Object (File)
Tue, Nov 5, 8:10 PM
View All Files
Subscribers
• abosh
• adrian
tomek

Details

Reviewers
varun
ashoat
atul
Commits
rCOMM57090061bb3d: [Nix] Add cmake-format to dev shell
Summary

Add cmake-lint command to dev shell

Depends on D4294

Test Plan
nix develop
cmake-lint --help

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 18 2022, 2:52 PM
Herald added subscribers: • abosh, • adrian, tomek. · View Herald TranscriptJul 18 2022, 2:52 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 18 2022, 2:56 PM
Harbormaster failed remote builds in B10597: Diff 14590!
• jon updated this revision to Diff 14591.Jul 18 2022, 3:24 PM

Rebase onto current master

• jon updated this revision to Diff 14593.Jul 18 2022, 3:36 PM

Cherry-pick to different branch

Harbormaster completed remote builds in B10598: Diff 14591.Jul 18 2022, 3:38 PM
• jon added a parent revision: D4565: [Chore] Lint services/backup/CMakeLists.txt.Jul 18 2022, 3:40 PM
• jon removed a parent revision: D4294: [nix] Add dependencies needed to compile native modules.
• jon removed a parent revision: D4565: [Chore] Lint services/backup/CMakeLists.txt.
• jon added a child revision: D4565: [Chore] Lint services/backup/CMakeLists.txt.
Harbormaster completed remote builds in B10600: Diff 14593.Jul 18 2022, 3:48 PM
• jon requested review of this revision.Jul 18 2022, 3:48 PM
• jon added a child revision: D4568: [Chore] Lint native/android/app/CMakeLists.txt.Jul 18 2022, 4:23 PM
• jon added a child revision: D4569: [Chore] Lint services/lib/cmake-components/grpc.cmake.
• jon added a child revision: D4566: [Chore] Lint services/tunnelbroker/CMakeLists.txt.Jul 18 2022, 4:27 PM
• jon added a child revision: D4567: [Chore] Lint services/blob/CMakeLists.txt.
atul accepted this revision.Jul 18 2022, 5:58 PM

Looks good to me, accepting and adding @ashoat as blocking reviewer since this introduces a new dependency.

(In the future it'd probably be helpful to link to something that shows what cmake-format corresponds to eg https://github.com/NixOS/nixpkgs/blob/nixos-22.05/pkgs/development/tools/cmake-format/default.nix or a GitHub repo or something)

This revision is now accepted and ready to land.Jul 18 2022, 5:58 PM
atul added 1 blocking reviewer(s): ashoat.Jul 18 2022, 5:59 PM
atul added a parent revision: D4294: [nix] Add dependencies needed to compile native modules.
This revision now requires review to proceed.Jul 18 2022, 5:59 PM
• jon added a comment.Jul 18 2022, 6:22 PM
In D4564#130255, @atul wrote:

(In the future it'd probably be helpful to link to something that shows what cmake-format corresponds to eg https://github.com/NixOS/nixpkgs/blob/nixos-22.05/pkgs/development/tools/cmake-format/default.nix or a GitHub repo or something)

Do you mean like which upstream it uses? (e.g. https://github.com/cheshirekow/cmake_format)

ashoat added a comment.Jul 19 2022, 8:18 AM

Wondering where the config for cmake-format goes, and if there's a way to configure the max line length

ashoat accepted this revision.Jul 19 2022, 8:22 AM
This revision is now accepted and ready to land.Jul 19 2022, 8:22 AM
• jon added a comment.Jul 20 2022, 7:39 AM

Wondering where the config for cmake-format goes, and if there's a way to configure the max line length

Default is 80

• jon added a comment.Jul 20 2022, 11:35 AM

@atul not sure what format you wanted the info, but with nix you can also just query the underlying package:

$ nix eval nixpkgs#cmake-format.meta.homepage
"https://github.com/cheshirekow/cmake_format"
atul added a comment.Jul 20 2022, 11:37 AM
In D4564#131048, @jon wrote:

@atul not sure what format you wanted the info, but with nix you can also just query the underlying package:

$ nix eval nixpkgs#cmake-format.meta.homepage
"https://github.com/cheshirekow/cmake_format"

Oh sweet TIL, I'll jot that down

Closed by commit rCOMM57090061bb3d: [Nix] Add cmake-format to dev shell (authored by • jon). · Explain WhyJul 20 2022, 12:00 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM57090061bb3d: [Nix] Add cmake-format to dev shell.
• jon removed a parent revision: D4294: [nix] Add dependencies needed to compile native modules.Jul 27 2022, 12:25 PM

Revision Contents
Changeset List

PathSize
nix/
2 lines

Diff 14593

View Options

nix/dev-shell.nix

Loading...