Page MenuHomePhabricator
Differential D4950

[native] add c++11 flag to build
ClosedPublic
Actions

Authored by varun on Aug 25 2022, 4:03 AM.
Tags
None
Referenced Files
F3369675: D4950.diff
Mon, Nov 25, 11:09 PM
Unknown Object (File)
Mon, Nov 11, 12:30 PM
Unknown Object (File)
Fri, Nov 8, 4:05 AM
Unknown Object (File)
Oct 26 2024, 2:11 AM
Unknown Object (File)
Oct 23 2024, 9:59 AM
Unknown Object (File)
Oct 19 2024, 1:47 AM
Unknown Object (File)
Oct 19 2024, 1:47 AM
Unknown Object (File)
Oct 19 2024, 1:47 AM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
• karol
atul
Commits
rCOMMe06b3c38cc10: [native] add c++11 flag to build
Summary

this ensures that the compiler knows which edition of C++ to use.

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Branch
identity-client (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Aug 25 2022, 4:03 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptAug 25 2022, 4:03 AM
varun updated this revision to Diff 15972.Aug 25 2022, 4:04 AM

Only add flag if it exists

varun added a child revision: D4951: [native] remove unused types.Aug 25 2022, 4:06 AM
Harbormaster completed remote builds in B11608: Diff 15971.Aug 25 2022, 4:13 AM
Harbormaster completed remote builds in B11609: Diff 15972.
varun requested review of this revision.Aug 25 2022, 4:14 AM
varun added 1 blocking reviewer(s): atul.Aug 25 2022, 10:31 AM
atul accepted this revision.Aug 25 2022, 11:11 AM

Looks reasonable based on the example here: https://docs.rs/cxx-build/latest/cxx_build/#example. Guessing we're going with C++ 11 here because it's the lowest common denominator across native?

varun added a comment.Aug 25 2022, 11:12 AM
In D4950#143596, @atul wrote:

Looks reasonable based on the example here: https://docs.rs/cxx-build/latest/cxx_build/#example. Guessing we're going with C++ 11 here because it's the lowest common denominator across native?

yeah that's right. hopefully we can bump native to C++20 and then upgrade this as well

varun removed 1 blocking reviewer(s): tomek.Aug 25 2022, 11:13 AM
This revision is now accepted and ready to land.Aug 25 2022, 11:13 AM
atul added a comment.Aug 25 2022, 11:28 AM

hopefully we can bump native to C++20 and then upgrade this as well

I think realistically C++ 14, but yeah anything >= 11 should be good

Closed by commit rCOMMe06b3c38cc10: [native] add c++11 flag to build (authored by varun). · Explain WhyAug 25 2022, 11:34 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe06b3c38cc10: [native] add c++11 flag to build.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
grpc/
grpc_client/
2 lines

Diff 15971

View Options

native/cpp/CommonCpp/grpc/grpc_client/build.rs

Loading...