This differential creates static variable with tokio runtime. This runtime will be used to execute tasks with gRPC calls.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/grpc/blob_client/rust/src/lib.rs | ||
|---|---|---|
| 10 | Do we really need to use Arc? | |
| native/cpp/CommonCpp/grpc/blob_client/rust/src/lib.rs | ||
|---|---|---|
| 10 | No, global singletons do not need Arc. karol has moved this work to https://linear.app/comm/issue/ENG-1732 | |
| native/cpp/CommonCpp/grpc/blob_client/rust/src/lib.rs | ||
|---|---|---|
| 10 | Agree, Arc is not needed here. I will use Rc instead. | |
| native/cpp/CommonCpp/grpc/blob_client/rust/src/lib.rs | ||
|---|---|---|
| 10 | Sorry for the confusion above - actually I do not even need Rc<> here. | |
| native/cpp/CommonCpp/grpc/blob_client/rust/src/lib.rs | ||
|---|---|---|
| 14 ↗ | (On Diff #16409) | Generally I prefer expect. At least it emits an error message which then you can search for in the code base. |
Comment Actions
I created this revision when I thought my blob client will be a separate binary. But we agreed that we will have one Rust crate for all native gRPC so I assume that my blob client will be using the same runtime that is already defined in grpc_client/src/lib.rs and used by identity client. So we can either abandon this revision, or use it to update runtime definition that is already on master once grpc_client refactor is done.
Comment Actions
Refactor after varun's changes. Introduced changes to runtime declaration - Wrapping in Arc is not necessary